Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bug fix for UTF-8 check #1559

Merged
merged 1 commit into from Nov 16, 2019
Merged

Bug fix for UTF-8 check #1559

merged 1 commit into from Nov 16, 2019

Conversation

yoganandc
Copy link
Contributor

Description

Pretty straight-forward, e was not defined causing glances to crash when encoding is not UTF-8

With this fix, a warning is appended to the log. Reproduced below:

2019-11-14 05:27:38,350 -- WARNING -- UTF-8 is mandatory for sparklines ('ascii' codec can't encode characters in position 0-39: ordinal not in range(128))

Resume

  • Bug fix: yes
  • New feature: no
  • Fixed tickets: (none)

@yoganandc yoganandc changed the title Update glances_sparklines.py Bug fix for UTF-8 check Nov 14, 2019
@coveralls
Copy link

Coverage Status

Coverage increased (+0.009%) to 39.602% when pulling 3752f1f on yoganandc:patch-1 into 7228a91 on nicolargo:develop.

@nicolargo nicolargo merged commit 9eb4833 into nicolargo:develop Nov 16, 2019
@nicolargo
Copy link
Owner

Thanks @yoganandc !

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants