Change percentage bars to use an explicit exception for value checks #683
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The percentage bars will now use an AssertionError directly if the provided values are outside of the expected range (0-100 inclusive).
I was using Bandit to check for potential vulnerabilities in a few popular Python projects and this came up as a warning:
As per the warning,
assert
statements are stripped out if compiling with optimized bytecode (-O option) in Python. Here's a StackOverflow question with a little discussion and the original Python docs.Oh, as a quick postscript, these tests run fine on OSX, so perhaps the Linux checks could be made to include OSX when running the tests?