[HttpFoundation] AbstractCookieHandlerTest with Response native sendHeaders #15

cvilleger · 2018-04-05T12:33:25Z

Q	A
Branch?	3.4
Bug fix?	yes
New feature?	no
BC breaks?	no
Deprecations?	no
Tests pass?	yes
Fixed tickets	symfony#25344
License	MIT
Doc PR	-

nicolas-grekas · 2018-04-05T16:34:54Z

src/Symfony/Component/HttpFoundation/Tests/Fixtures/common.inc

@@ -0,0 +1,151 @@
+<?php
+
+use Symfony\Component\HttpFoundation\Session\Storage\Handler\AbstractSessionHandler;


should be removed

Done, thanks.

nicolas-grekas · 2018-04-05T16:35:16Z

src/Symfony/Component/HttpFoundation/Tests/Fixtures/common.inc

+error_reporting(-1);
+ini_set('html_errors', 0);
+ini_set('display_errors', 1);
+ini_set('session.gc_probability', 0);


all ini_set for session.* should be removed

Done, thanks.

nicolas-grekas · 2018-04-05T16:35:27Z

src/Symfony/Component/HttpFoundation/Tests/Fixtures/common.inc

+});
+ob_start();
+
+class TestSessionHandler extends AbstractSessionHandler


should be removed

Done, thanks.

nicolas-grekas · 2018-04-05T16:37:40Z

src/Symfony/Component/HttpFoundation/Tests/Fixtures/send_headers_cookie_samesite.php

+
+$r = new Response();
+$r->headers->set('Date', 'Thu, 02 Feb 2012 12:12:12 GMT');
+$r->headers->setCookie(new Cookie('SameSite', 'Strict'));


this creates a cookie with name SameSite, and value Strict, that's not the feature we want to test
instead, we want to enable the $sameSite parameter of the constructor of the Cookie class.

Done, thanks.

nicolas-grekas · 2018-04-05T16:38:12Z

src/Symfony/Component/HttpFoundation/Tests/HeaderTest.php

+
+use PHPUnit\Framework\TestCase;
+
+class HeaderTest extends TestCase


I'd suggest to name this RequestFunctionalTest instead

Done, thanks.

nicolas-grekas · 2018-04-05T16:38:38Z

src/Symfony/Component/HttpFoundation/Tests/HeaderTest.php

+        $result = file_get_contents('http://localhost:8054/send_headers_cookie_samesite.php');
+        $this->assertStringEqualsFile(__DIR__ . '/Fixtures/send_headers_cookie_samesite.expected', $result);
+    }
+


Removed, thanks.

nicolas-grekas · 2018-04-05T16:38:55Z

src/Symfony/Component/HttpFoundation/Tests/Fixtures/send_headers_cookie_samesite.php

+<?php
+
+use Symfony\Component\HttpFoundation\Cookie;
+use Symfony\Component\HttpFoundation\Response;


This is my $r below

This PR was merged into the 1.3-dev branch. Discussion ---------- Use adapter for UploadedFile objects Replaces symfony#68, fixes #15, #39 Commits ------- a4f9f6d Use adapter for UploadedFile objects

…hen publishing a message. (jwage) This PR was squashed before being merged into the 6.4 branch. Discussion ---------- [Messenger] [Amqp] Handle AMQPConnectionException when publishing a message. | Q | A | ------------- | --- | Branch? | 6.4 | Bug fix? | yes | New feature? | no | Deprecations? | no | Issues | Fix symfony#36538 Fix symfony#48241 | License | MIT If you have a message handler that dispatches messages to another queue, you can encounter `AMQPConnectionException` with the message "Library error: a SSL error occurred" or "a socket error occurred" depending on if you are using tls or not or if you are running behind a load balancer or not. You can manually reproduce this issue by dispatching a message where the handler then dispatches another message to a different queue, then go to rabbitmq admin and close the connection manually, then dispatch another message and when the message handler goes to dispatch the other message, you will get this exception: ``` a socket error occurred #0 /vagrant/vendor/symfony/amqp-messenger/Transport/AmqpTransport.php(60): Symfony\Component\Messenger\Bridge\Amqp\Transport\AmqpSender->send() #1 /vagrant/vendor/symfony/messenger/Middleware/SendMessageMiddleware.php(62): Symfony\Component\Messenger\Bridge\Amqp\Transport\AmqpTransport->send() #2 /vagrant/vendor/symfony/messenger/Middleware/FailedMessageProcessingMiddleware.php(34): Symfony\Component\Messenger\Middleware\SendMessageMiddleware->handle() #3 /vagrant/vendor/symfony/messenger/Middleware/DispatchAfterCurrentBusMiddleware.php(61): Symfony\Component\Messenger\Middleware\FailedMessageProcessingMiddleware->handle() #4 /vagrant/vendor/symfony/messenger/Middleware/RejectRedeliveredMessageMiddleware.php(41): Symfony\Component\Messenger\Middleware\DispatchAfterCurrentBusMiddleware->handle() #5 /vagrant/vendor/symfony/messenger/Middleware/AddBusNameStampMiddleware.php(37): Symfony\Component\Messenger\Middleware\RejectRedeliveredMessageMiddleware->handle() #6 /vagrant/vendor/symfony/messenger/Middleware/TraceableMiddleware.php(40): Symfony\Component\Messenger\Middleware\AddBusNameStampMiddleware->handle() #7 /vagrant/vendor/symfony/messenger/MessageBus.php(70): Symfony\Component\Messenger\Middleware\TraceableMiddleware->handle() #8 /vagrant/vendor/symfony/messenger/TraceableMessageBus.php(38): Symfony\Component\Messenger\MessageBus->dispatch() #9 /vagrant/src/Messenger/MessageBus.php(37): Symfony\Component\Messenger\TraceableMessageBus->dispatch() #10 /vagrant/vendor/symfony/mailer/Mailer.php(66): App\Messenger\MessageBus->dispatch() #11 /vagrant/src/Mailer/Mailer.php(83): Symfony\Component\Mailer\Mailer->send() #12 /vagrant/src/Mailer/Mailer.php(96): App\Mailer\Mailer->send() #13 /vagrant/src/MessageHandler/Trading/StrategySubscriptionMessageHandler.php(118): App\Mailer\Mailer->sendEmail() #14 /vagrant/src/MessageHandler/Trading/StrategySubscriptionMessageHandler.php(72): App\MessageHandler\Trading\StrategySubscriptionMessageHandler->handle() #15 /vagrant/vendor/symfony/messenger/Middleware/HandleMessageMiddleware.php(152): App\MessageHandler\Trading\StrategySubscriptionMessageHandler->__invoke() #16 /vagrant/vendor/symfony/messenger/Middleware/HandleMessageMiddleware.php(91): Symfony\Component\Messenger\Middleware\HandleMessageMiddleware->callHandler() #17 /vagrant/vendor/symfony/messenger/Middleware/SendMessageMiddleware.php(71): Symfony\Component\Messenger\Middleware\HandleMessageMiddleware->handle() #18 /vagrant/vendor/symfony/messenger/Middleware/FailedMessageProcessingMiddleware.php(34): Symfony\Component\Messenger\Middleware\SendMessageMiddleware->handle() #19 /vagrant/vendor/symfony/messenger/Middleware/DispatchAfterCurrentBusMiddleware.php(68): Symfony\Component\Messenger\Middleware\FailedMessageProcessingMiddleware->handle() #20 /vagrant/vendor/symfony/messenger/Middleware/RejectRedeliveredMessageMiddleware.php(41): Symfony\Component\Messenger\Middleware\DispatchAfterCurrentBusMiddleware->handle() #21 /vagrant/vendor/symfony/messenger/Middleware/AddBusNameStampMiddleware.php(37): Symfony\Component\Messenger\Middleware\RejectRedeliveredMessageMiddleware->handle() #22 /vagrant/vendor/symfony/messenger/Middleware/TraceableMiddleware.php(40): Symfony\Component\Messenger\Middleware\AddBusNameStampMiddleware->handle() #23 /vagrant/vendor/symfony/messenger/MessageBus.php(70): Symfony\Component\Messenger\Middleware\TraceableMiddleware->handle() #24 /vagrant/vendor/symfony/messenger/TraceableMessageBus.php(38): Symfony\Component\Messenger\MessageBus->dispatch() #25 /vagrant/vendor/symfony/messenger/RoutableMessageBus.php(54): Symfony\Component\Messenger\TraceableMessageBus->dispatch() #26 /vagrant/vendor/symfony/messenger/Worker.php(162): Symfony\Component\Messenger\RoutableMessageBus->dispatch() #27 /vagrant/vendor/symfony/messenger/Worker.php(109): Symfony\Component\Messenger\Worker->handleMessage() #28 /vagrant/vendor/symfony/messenger/Command/ConsumeMessagesCommand.php(238): Symfony\Component\Messenger\Worker->run() #29 /vagrant/vendor/symfony/console/Command/Command.php(326): Symfony\Component\Messenger\Command\ConsumeMessagesCommand->execute() #30 /vagrant/vendor/symfony/console/Application.php(1096): Symfony\Component\Console\Command\Command->run() #31 /vagrant/vendor/symfony/framework-bundle/Console/Application.php(126): Symfony\Component\Console\Application->doRunCommand() #32 /vagrant/vendor/symfony/console/Application.php(324): Symfony\Bundle\FrameworkBundle\Console\Application->doRunCommand() #33 /vagrant/vendor/symfony/framework-bundle/Console/Application.php(80): Symfony\Component\Console\Application->doRun() #34 /vagrant/vendor/symfony/console/Application.php(175): Symfony\Bundle\FrameworkBundle\Console\Application->doRun() #35 /vagrant/vendor/symfony/runtime/Runner/Symfony/ConsoleApplicationRunner.php(49): Symfony\Component\Console\Application->run() #36 /vagrant/vendor/autoload_runtime.php(29): Symfony\Component\Runtime\Runner\Symfony\ConsoleApplicationRunner->run() #37 /vagrant/bin/console(11): require_once('...') #38 {main} ``` TODO: - [x] Add test for retry logic when publishing messages Commits ------- f123370 [Messenger] [Amqp] Handle AMQPConnectionException when publishing a message.

cvilleger added 2 commits April 5, 2018 14:19

AbstractCookieHandlerTest with Response native sendHeaders test

1889d54

Namespace moved to HttpFoundation/Tests and use setCookie / new Cookie

11f14c2

cvilleger force-pushed the same-site-cookie branch 2 times, most recently from feff19a to 11f14c2 Compare April 5, 2018 15:50

nicolas-grekas requested changes Apr 5, 2018

View reviewed changes

Test $sameSite from Cookie and remove useless code in common.inc

30cac90

nicolas-grekas merged commit 30cac90 into nicolas-grekas:same-site-cookie Apr 6, 2018

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

[HttpFoundation] AbstractCookieHandlerTest with Response native sendHeaders #15

[HttpFoundation] AbstractCookieHandlerTest with Response native sendHeaders #15

cvilleger commented Apr 5, 2018

nicolas-grekas Apr 5, 2018

cvilleger Apr 6, 2018

nicolas-grekas Apr 5, 2018

cvilleger Apr 6, 2018

nicolas-grekas Apr 5, 2018

cvilleger Apr 6, 2018

nicolas-grekas Apr 5, 2018

cvilleger Apr 6, 2018

nicolas-grekas Apr 5, 2018

cvilleger Apr 6, 2018

nicolas-grekas Apr 5, 2018

cvilleger Apr 6, 2018

nicolas-grekas Apr 5, 2018

cvilleger Apr 6, 2018

		@@ -0,0 +1,151 @@
		<?php

		use Symfony\Component\HttpFoundation\Session\Storage\Handler\AbstractSessionHandler;


		use PHPUnit\Framework\TestCase;

		class HeaderTest extends TestCase

[HttpFoundation] AbstractCookieHandlerTest with Response native sendHeaders #15

[HttpFoundation] AbstractCookieHandlerTest with Response native sendHeaders #15

Conversation

cvilleger commented Apr 5, 2018

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment