Modified RunnableHandler to process runnables FIFO #193
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contrary to the expectations of every Handler, I found that the RunnableHandler processes runnables in a LIFO (stack-like fashion). The correct approach is to process them in order and then clear the list, as I've done here. This not only processes the items in FIFO order as expected, it also avoids any overhead of trying to remove the first element of the ArrayList.
|
There's a shortcoming with this implementation. This list should be implemented as a LinkedList working as a Queue. Making the changes. |
|
This fix is actually good, but I've already resubmitted. I was worried about synchronization, but you had already taken care of that. This should be changed as I've indicated: #194 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Contrary to the expectations of every Handler, I found that the RunnableHandler processes runnables in a LIFO (stack-like fashion).
The correct approach is to process them in order and then clear the list, as I've done here. This not only processes the items in FIFO order as expected, it also avoids any overhead of trying to remove the first element of the ArrayList.