Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

override functionality about showFilterList #339

Closed
hoyeol opened this issue Jun 2, 2015 · 4 comments
Closed

override functionality about showFilterList #339

hoyeol opened this issue Jun 2, 2015 · 4 comments

Comments

@hoyeol
Copy link

hoyeol commented Jun 2, 2015

there "showFilterList" function using e.pageX, e.pageY for decide popup location.
but e.pageX, e.pageY returns position relative to the left edge of the document..
that's a problem when i using pivottable with "nested" div structure.
with "nested" div structure, e.pageX/e.pageY popup location is too far from click point.

so i modified code & using like this.

// in showFilterList function..
var offset = $(e.currentTarget).position();
var top = offset.top + 10;
var left = offset.left + 10;
valueList.css({
  left: left,
  top: top
}).toggle();

if provide override "showFilterList" function, does not need to modify there pivot source code

@nicolaskruchten
Copy link
Owner

Can you provide an example of the 'nested div' structure which poses a problem? I have been unable to replicate this issue...

@hoyeol
Copy link
Author

hoyeol commented Jun 3, 2015

here is the sample. https://gist.github.com/hoyeol/a049a90c524273d19c45

@nicolaskruchten
Copy link
Owner

Super, thanks! I'll take a look :)

nicolaskruchten added a commit that referenced this issue Jun 19, 2015
@nicolaskruchten
Copy link
Owner

Thanks for this test case. I've actually just implemented your change and it looks like it works :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants