Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

FramesCollection -- use FrameConnotationProvider instead #216

Closed
nicolay-r opened this issue Nov 29, 2021 · 0 comments
Closed

FramesCollection -- use FrameConnotationProvider instead #216

nicolay-r opened this issue Nov 29, 2021 · 0 comments
Assignees
Labels
enhancement New feature or request

Comments

@nicolay-r
Copy link
Owner

nicolay-r commented Nov 29, 2021

Reason: the common method required from FramesCollection is a try_get_frame_polarity. The latter is related to frame connotations, where sentiment connotation is a one of many other types of possible (potential) connotations.
Related to #118

In further:

  • sentiment connotation is a particular type (class);
  • connotations might be schema;
@nicolay-r nicolay-r added the enhancement New feature or request label Nov 29, 2021
@nicolay-r nicolay-r self-assigned this Nov 29, 2021
@nicolay-r nicolay-r changed the title FramesCollection -- use FrameConnotationProvider instead FramesCollection -- use FrameConnotationProvider instead Nov 29, 2021
nicolay-r added a commit that referenced this issue Dec 10, 2021
nicolay-r added a commit that referenced this issue Dec 10, 2021
nicolay-r added a commit that referenced this issue Dec 11, 2021
nicolay-r added a commit that referenced this issue Dec 12, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

1 participant