Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

OpinionsProvider -- performs two actions, including ids assignation #236

Closed
nicolay-r opened this issue Dec 19, 2021 · 0 comments
Closed

OpinionsProvider -- performs two actions, including ids assignation #236

nicolay-r opened this issue Dec 19, 2021 · 0 comments
Assignees
@nicolay-r
Labels
critical enhancement New feature or request task

Comments

@nicolay-r
Copy link
Owner

nicolay-r commented Dec 19, 2021 •
edited
Loading

This should be refactred in a form of a pipeline.

AREkit/arekit/common/data/input/providers/opinions.py

Line 8 in 075412d

class OpinionProvider(object):

@nicolay-r nicolay-r added the question Further information is requested label Dec 19, 2021
@nicolay-r nicolay-r self-assigned this Dec 19, 2021
@nicolay-r nicolay-r added enhancement New feature or request task and removed question Further information is requested labels Dec 20, 2021
nicolay-r added a commit that referenced this issue Dec 20, 2021
@nicolay-r
Pipeline generalization. Related to #154 (#236 pre refactoring), #224 …
f8aa3a3 
…proceeds.
nicolay-r added a commit that referenced this issue Dec 29, 2021
@nicolay-r
#236 done #233 to do (related)
375483c
@nicolay-r nicolay-r mentioned this issue Dec 30, 2021
Closed
nicolay-r added a commit that referenced this issue Dec 30, 2021
@nicolay-r
#236 done.
53b5688
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@nicolay-r nicolay-r

Labels
critical enhancement New feature or request task
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@nicolay-r