Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

News -- text-opinions provider and entities access API might be a part of a ParsedNews by means of NewsParser (new class) #224

Closed
nicolay-r opened this issue Dec 12, 2021 · 2 comments
Closed

News -- text-opinions provider and entities access API might be a part of a ParsedNews by means of NewsParser (new class) #224

nicolay-r opened this issue Dec 12, 2021 · 2 comments
Assignees
@nicolay-r
Labels
critical enhancement New feature or request task

Comments

@nicolay-r
Copy link
Owner

nicolay-r commented Dec 12, 2021 •
edited
Loading

Reason is to utilize ParsedNews and prevent from keeping News instances in addition.!
@nicolay-r nicolay-r added the enhancement New feature or request label Dec 12, 2021
@nicolay-r nicolay-r changed the title News -- text-opinions provider API might be a part of ParsedNews. News -- text-opinions provider API might be a part of a new class NewsParser Dec 13, 2021
@nicolay-r nicolay-r self-assigned this Dec 13, 2021
@nicolay-r nicolay-r changed the title News -- text-opinions provider API might be a part of a new class NewsParser News -- text-opinions provider and entities access API might be a part of a new class NewsParser Dec 13, 2021
@nicolay-r nicolay-r changed the title News -- text-opinions provider and entities access API might be a part of a new class NewsParser News -- text-opinions provider and entities access API might be a part of a ParsedNews by means of NewsParser (new class) Dec 13, 2021
nicolay-r added a commit that referenced this issue Dec 14, 2021
@nicolay-r
#220 Done. #224 Related.
4f7830b
nicolay-r added a commit that referenced this issue Dec 15, 2021
@nicolay-r
#224. Huge refactoring. Now frames are not supported as a part of the…
9852499 
… text processing pipeline
@nicolay-r
Copy link
Owner Author

nicolay-r commented Dec 15, 2021 •
edited
Loading

Now frames annotation is not supported both:

  1. As a part of the pipeline (requires to inherit such parser from the TextParserPipelineItem)
  2. The latter requires lemmatization! (Lemmatization should be a part of the frames processing pipeline stage #226)

@nicolay-r nicolay-r mentioned this issue Dec 15, 2021
Closed
@nicolay-r
Copy link
Owner Author

nicolay-r commented Dec 16, 2021 •
edited
Loading

Concept:

  1. ProcessNews -> ParsedNews
  2. Provide such API for ParsedNews

According to the original Sentiment Attitude Extraction Task, entities were a part of the News and hence, before this issue we may consider opinion_provider as a News-related API. As we would like to generalize it, there is a need to provide such operation for ParsedNews

nicolay-r added a commit that referenced this issue Dec 16, 2021
@nicolay-r
#224. Related refactoring.
bf725bc
This was referenced Dec 17, 2021
Closed
Closed
nicolay-r added a commit that referenced this issue Dec 18, 2021
@nicolay-r
#224. Closed. #231 Related refactoring. Lead to #232.
7544fe9
nicolay-r added a commit that referenced this issue Dec 18, 2021
@nicolay-r
#161 related, due to #224 refactoring.
9fc5d89
nicolay-r added a commit that referenced this issue Dec 20, 2021
@nicolay-r
Pipeline generalization. Related to #154 (#236 pre refactoring), #224 …
f8aa3a3 
…proceeds.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@nicolay-r nicolay-r

Labels
critical enhancement New feature or request task
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@nicolay-r