Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

DocumentOperations -- parsed docs related API is not related to the expetiment concepts. #249

Closed
4 tasks done
nicolay-r opened this issue Jan 3, 2022 · 0 comments
Closed
4 tasks done

DocumentOperations -- parsed docs related API is not related to the expetiment concepts. #249

nicolay-r opened this issue Jan 3, 2022 · 0 comments
Assignees
@nicolay-r
Labels
enhancement New feature or request task

Comments

@nicolay-r
Copy link
Owner

nicolay-r commented Jan 3, 2022 •
edited
Loading

  • Remove parse_doc and hence TextParser from DocumentOperations
  • Remove depedency of opinion annot from DocumentOperations parsed news provider. (see previous item)
  • Remove from BertExperimentInputSerializer
  • NetworkInputHelper -- provide text_parser instead

Profits:

  • we will have a single text parsing iteration (instead of a couple)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@nicolay-r nicolay-r

Labels
enhancement New feature or request task
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@nicolay-r