Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fill -- in case of None rows count tqdm throws exception #458

Closed
nicolay-r opened this issue May 8, 2023 · 0 comments
Closed

fill -- in case of None rows count tqdm throws exception #458

nicolay-r opened this issue May 8, 2023 · 0 comments
Assignees
@nicolay-r
Labels
bug Something isn't working

Comments

@nicolay-r
Copy link
Owner

AREkit/arekit/common/data/storages/base.py

Lines 46 to 52 in 5e92893

def fill(self, iter_rows_func, columns_provider, rows_count=None, desc=""):
assert(callable(iter_rows_func))
assert(isinstance(columns_provider, BaseColumnsProvider))
it = progress_bar_defined(iterable=iter_rows_func(False),
desc="{fmt}".format(fmt=desc),
total=rows_count)

@nicolay-r nicolay-r added the bug Something isn't working label May 8, 2023
@nicolay-r nicolay-r self-assigned this May 8, 2023
nicolay-r added a commit that referenced this issue May 8, 2023
@nicolay-r
#459 done, caused #460, #458 fixed. Large update that provides a stor…
cf6a5de 
…age that keeps only one row in memory! The latter is supplemented by CSV writer.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@nicolay-r nicolay-r

Labels
bug Something isn't working
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@nicolay-r