Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

SynonymsCollection -- setup default value of iter_group_values_lists to [] #468

Closed
3 tasks done
nicolay-r opened this issue May 13, 2023 · 0 comments
Closed
3 tasks done

SynonymsCollection -- setup default value of iter_group_values_lists to [] #468

nicolay-r opened this issue May 13, 2023 · 0 comments
Assignees
@nicolay-r
Labels
enhancement New feature or request

Comments

@nicolay-r
Copy link
Owner

nicolay-r commented May 13, 2023 •
edited
Loading

Reason: simplify implementation and usage

  • also provide the description that this collection originates and a part of the studes/paper
  • complete the rest parameters
  • debug parameter is always utilized in False mode.

AREkit/arekit/contrib/utils/synonyms/stemmer_based.py

Line 5 in 3583f38

class StemmerBasedSynonymCollection(SynonymsCollection):

@nicolay-r nicolay-r added the enhancement New feature or request label May 13, 2023
@nicolay-r nicolay-r self-assigned this May 13, 2023
@nicolay-r nicolay-r changed the title SynonymsCollection iter_group_values_lists -- setup default value as [] SynonymsCollection -- setup default value of iter_group_values_lists as [] May 13, 2023
@nicolay-r nicolay-r changed the title SynonymsCollection -- setup default value of iter_group_values_lists as [] SynonymsCollection -- setup default value of iter_group_values_lists to [] May 13, 2023
nicolay-r added a commit that referenced this issue May 17, 2023
@nicolay-r
#468 -- iter_group_values_lists is considered as None by default (e…
2b10c4f 
…mpty Synonyms collection)
nicolay-r added a commit that referenced this issue May 17, 2023
@nicolay-r
#468 -- removed parameter debug in nested classes
03e30f5
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@nicolay-r nicolay-r

Labels
enhancement New feature or request
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@nicolay-r