Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

DocumentOperations -- rename to providers #471

Closed
5 tasks done
Tracked by #466
nicolay-r opened this issue May 15, 2023 · 1 comment
Closed
5 tasks done
Tracked by #466

DocumentOperations -- rename to providers #471

nicolay-r opened this issue May 15, 2023 · 1 comment
Assignees
@nicolay-r
Labels
documentation Improvements or additions to documentation enhancement New feature or request

Comments

@nicolay-r
Copy link
Owner

nicolay-r commented May 15, 2023 •
edited
Loading

Reason: earlier, operations were used to emphasize that the class has a variety operations that related to Documents, while now the latter is only utilized for providing documents

  • Move it from experiment to data section
  • Rename class names
  • Variables renaming
  • Rename get_doc method to by_id
  • short API calls from lambda doc_id: doc_ops.get_doc to doc_ops.get_doc

https://github.com/nicolay-r/AREkit/blob/5441aa879213bea3e127f2f0965bf424fa8e5577/arekit/common/experiment/api/ops_doc.py#L1C3-L6
@nicolay-r nicolay-r added documentation Improvements or additions to documentation enhancement New feature or request labels May 15, 2023
@nicolay-r nicolay-r self-assigned this May 15, 2023
@nicolay-r
Copy link
Owner Author

#470 related

nicolay-r added a commit that referenced this issue May 17, 2023
@nicolay-r
#471 shortening lambda
3a8b26e
@nicolay-r nicolay-r mentioned this issue May 18, 2023
Closed
nicolay-r added a commit that referenced this issue May 24, 2023
@nicolay-r
#471 related
165c308
nicolay-r added a commit that referenced this issue Jun 20, 2023
@nicolay-r
#471 related
aa60331
nicolay-r added a commit that referenced this issue Jun 20, 2023
@nicolay-r
#471 refactor filenames
b19291e
nicolay-r added a commit that referenced this issue Jun 20, 2023
@nicolay-r
#471 from DocumentProviders to DocumentProvider
3e73599
nicolay-r added a commit that referenced this issue Jun 20, 2023
@nicolay-r
#471 considering util pipelines
286fcf7
@nicolay-r nicolay-r mentioned this issue Jun 18, 2023
Closed
4 tasks
nicolay-r added a commit that referenced this issue Jun 20, 2023
@nicolay-r
#471 variables renaming.
6072696
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@nicolay-r nicolay-r

Labels
documentation Improvements or additions to documentation enhancement New feature or request
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@nicolay-r