Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

opinions=[] -- simplify usage of API [paper feedback] #478

Closed
nicolay-r opened this issue May 21, 2023 · 1 comment
Closed

opinions=[] -- simplify usage of API [paper feedback] #478

nicolay-r opened this issue May 21, 2023 · 1 comment
Assignees
@nicolay-r
Labels
enhancement New feature or request

Comments

@nicolay-r
Copy link
Owner

nicolay-r commented May 21, 2023 •
edited
Loading

Reason: there is no need declare this parameter, i.e. code is suppose to work the same way if the latter won't be provided in this case.

AREkit/tests/tutorials/test_tutorial_pipeline_text_opinion_annotation.py

Line 61 in 07bc73c

opinions=[], synonyms=synonyms, error_on_duplicates=True, error_on_synonym_end_missed=False),

@nicolay-r nicolay-r changed the title opinion=[] -- simplify usage of API opinions=[] -- simplify usage of API May 21, 2023
@nicolay-r nicolay-r self-assigned this May 21, 2023
@nicolay-r nicolay-r added the enhancement New feature or request label May 21, 2023
@nicolay-r nicolay-r changed the title opinions=[] -- simplify usage of API opinions=[] -- simplify usage of API [paper feedback] May 21, 2023
nicolay-r added a commit that referenced this issue May 22, 2023
@nicolay-r
#478 simplified API usage
a1bac39
@nicolay-r
Copy link
Owner Author

AREkit/arekit/contrib/utils/pipelines/sources/rusentrel/extract_text_opinions.py

Line 74 in 07bc73c

opinions=[], synonyms=synonyms, error_on_duplicates=True, error_on_synonym_end_missed=False),

@nicolay-r nicolay-r reopened this May 23, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@nicolay-r nicolay-r

Labels
enhancement New feature or request
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@nicolay-r