#478 simplified API usage

nicolay-r · May 22, 2023 · a1bac39 · a1bac39
1 parent 07bc73c
commit a1bac39
Show file tree

Hide file tree

Showing 4 changed files with 4 additions and 6 deletions.
diff --git a/arekit/contrib/utils/pipelines/sources/rusentrel/extract_text_opinions.py b/arekit/contrib/utils/pipelines/sources/rusentrel/extract_text_opinions.py
@@ -71,7 +71,7 @@ def nolabel_annotator(synonyms, terms_per_context, dist_in_sentences=0, no_label
                                                        dist_in_terms_bound=terms_per_context,
                                                        label_provider=ConstantLabelProvider(no_label)),
         create_empty_collection_func=lambda: OpinionCollection(
-            opinions=[], synonyms=synonyms, error_on_duplicates=True, error_on_synonym_end_missed=False),
+            synonyms=synonyms, error_on_duplicates=True, error_on_synonym_end_missed=False),
         value_to_group_id_func=lambda value:
         SynonymsCollectionValuesGroupingProviders.provide_existed_value(synonyms=synonyms, value=value))
 
@@ -83,7 +83,7 @@ def predefined_annotator(synonyms, labels_fmt):
         annot_algo=PredefinedOpinionAnnotationAlgorithm(
             lambda doc_id: __get_document_opinions(doc_id=doc_id, synonyms=synonyms, labels_fmt=labels_fmt)),
         create_empty_collection_func=lambda: OpinionCollection(
-            opinions=[], synonyms=synonyms, error_on_duplicates=True, error_on_synonym_end_missed=False),
+            synonyms=synonyms, error_on_duplicates=True, error_on_synonym_end_missed=False),
         value_to_group_id_func=lambda value:
         SynonymsCollectionValuesGroupingProviders.provide_existed_value(synonyms=synonyms, value=value))
 

diff --git a/arekit/contrib/utils/pipelines/sources/sentinerel/extract_text_opinions.py b/arekit/contrib/utils/pipelines/sources/sentinerel/extract_text_opinions.py
@@ -137,7 +137,6 @@ def create_nolabel_text_opinion_annotator(terms_per_context, dist_in_sents=0, sy
             dist_in_terms_bound=terms_per_context,
             label_provider=ConstantLabelProvider(NoLabel())),
         create_empty_collection_func=lambda: OpinionCollection(
-            opinions=[],
             synonyms=synonyms,
             error_on_duplicates=True,
             error_on_synonym_end_missed=False))

diff --git a/tests/contrib/utils/test_output.py b/tests/contrib/utils/test_output.py
@@ -87,8 +87,7 @@ def optional_test_output_formatter(self):
         opinion_view = BaseOpinionStorageView(opinion_storage)
 
         converter_part = text_opinion_linkages_to_opinion_collections_pipeline_part(
-            create_opinion_collection_func=lambda: OpinionCollection(opinions=[],
-                                                                     synonyms=synonyms,
+            create_opinion_collection_func=lambda: OpinionCollection(synonyms=synonyms,
                                                                      error_on_duplicates=True,
                                                                      error_on_synonym_end_missed=True),
             doc_ids_set={1},

diff --git a/tests/tutorials/test_tutorial_pipeline_text_opinion_annotation.py b/tests/tutorials/test_tutorial_pipeline_text_opinion_annotation.py
@@ -58,7 +58,7 @@ def test(self):
                 dist_in_terms_bound=50,
                 label_provider=ConstantLabelProvider(NoLabel())),
             create_empty_collection_func=lambda: OpinionCollection(
-                opinions=[], synonyms=synonyms, error_on_duplicates=True, error_on_synonym_end_missed=False),
+                synonyms=synonyms, error_on_duplicates=True, error_on_synonym_end_missed=False),
             value_to_group_id_func=lambda value:
             SynonymsCollectionValuesGroupingProviders.provide_existed_or_register_missed_value(
                 synonyms=synonyms, value=value))