Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Folding -- supposed to be in a form of algorithm, without ids storage #489

Closed
6 tasks done
Tracked by #466
nicolay-r opened this issue Jun 21, 2023 · 0 comments
Closed
6 tasks done
Tracked by #466

Folding -- supposed to be in a form of algorithm, without ids storage #489

nicolay-r opened this issue Jun 21, 2023 · 0 comments
Assignees
@nicolay-r
Labels
critical enhancement New feature or request

Comments

@nicolay-r
Copy link
Owner

nicolay-r commented Jun 21, 2023 •
edited
Loading

Reason: we need to provide ids aside. Folding and doc-ids are not the same entities in nature.

  • fold_doc_ids_set should have doc_ids as a parameter
  • ❌ Remove unided folding
  • ❌ Remove iter_doc_ids method (used in unided folding)
  • ❌ Remove contains_doc_id method
  • ❌ Remove iter_supported_data_types
  • ❌ Removed from SamplesIO (fdff30e)

AREkit/arekit/contrib/utils/pipelines/items/sampling/base.py

Line 57 in a624ae1

doc_ids_iter=data_folding.fold_doc_ids_set()[data_type],

@nicolay-r nicolay-r self-assigned this Jun 21, 2023
@nicolay-r nicolay-r added enhancement New feature or request critical labels Jun 21, 2023
@nicolay-r nicolay-r changed the title Folding -- supposed to be in a form of algorithm, without ids storage Folding -- supposed to be in a form of algorithm, without ids storage Jun 21, 2023
This was referenced Jun 20, 2023
Closed
Closed
Closed
nicolay-r added a commit that referenced this issue Jul 3, 2023
@nicolay-r
#489 done
b38995e
nicolay-r added a commit that referenced this issue Jul 3, 2023
@nicolay-r
#489 simplified API
2f9c150
This was referenced Aug 18, 2023
Closed
Closed
nicolay-r added a commit that referenced this issue Aug 19, 2023
@nicolay-r
#518 refactored, #489 related
5457ec9
nicolay-r added a commit that referenced this issue Sep 21, 2023
@nicolay-r
#489 related. Removed data_folding from SamplesIO and the related d…
fdff30e 
…ependencies
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@nicolay-r nicolay-r

Labels
critical enhancement New feature or request
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@nicolay-r