Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

DataFolding has dictionary type (Exception) #518

Closed
1 task done
nicolay-r opened this issue Aug 18, 2023 · 0 comments
Closed
1 task done

DataFolding has dictionary type (Exception) #518

nicolay-r opened this issue Aug 18, 2023 · 0 comments
Assignees
@nicolay-r
Labels
bug Something isn't working critical

Comments

@nicolay-r
Copy link
Owner

nicolay-r commented Aug 18, 2023 •
edited
Loading

Here, data_type has dict type, so we just need to direct access folding for the related type.
However, we need to consider the case of doc_ids when we do not provide folding.

#489 related

  • 🔧 Refactoring: remove moldings

AREkit/arekit/contrib/utils/pipelines/items/sampling/base.py

Line 56 in 2b2dd19

doc_ids_iter=data_folding.fold_doc_ids_set(doc_ids=doc_ids)[data_type],

https://github.com/nicolay-r/AREkit/blob/2b2dd19789bc8a09d25490f1cae147c4f2b8d8cf/arekit/contrib/utils/pipelines/items/sampling/base.py#L35-L56C59
@nicolay-r nicolay-r added the bug Something isn't working label Aug 18, 2023
@nicolay-r nicolay-r self-assigned this Aug 18, 2023
@nicolay-r nicolay-r changed the title DocIDs parameter is useless DataFolding has dictionary type (Exception) Aug 18, 2023
nicolay-r added a commit that referenced this issue Aug 19, 2023
@nicolay-r
#518 refactored, #489 related
5457ec9
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@nicolay-r nicolay-r

Labels
bug Something isn't working critical
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@nicolay-r