Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Forcibly re-queue uploads that stop due to an error such as "Can't connect" #1563

Closed
Tenome opened this issue Sep 14, 2021 · 5 comments
Closed

Comments

@Tenome
Copy link

Tenome commented Sep 14, 2021

I noticed someone grabbing some music from me whose upload was stopped due to "can't connect." When I click on them and hit Retry, it works just fine, so presumably the connection timed out or something. Can there be an option to automatically retry any uploads (and downloads if it isn't already a feature) so neither me nor the downloader have to hit Retry?

Thanks for your work.

@mathiascode
Copy link
Member

This is implemented for downloads, but not uploads yet.

@slook
Copy link
Member

slook commented Sep 15, 2021

When I click on them and hit Retry, it works just fine

It does for a single file, but selecting multiple files that all have the "Can't connect" status doesn't work (in 3.2.0.dev1), which makes it necessary to wait until all transfers have finished then go through each one individually. On slow connections this is very tedious (even when multiple upload slots are available).

Note that the Queue position of the stuck Uploads becomes duplicated in this scenario, which might be causing the inconsistent behaviour? Disconnecting+reconnecting doesn't resolve it, but restarting the application does, perhaps because all Queue position are then reset (perhaps "Can't connect" items need to be given a Null position in the Queue).

@mathiascode
Copy link
Member

It does for a single file, but selecting multiple files that all have the "Can't connect" status doesn't work (in 3.2.0.dev1), which makes it necessary to wait until all transfers have finished then go through each one individually. On slow connections this is very tedious (even when multiple upload slots are available).

This is fixed in 91049c3.

@mathiascode
Copy link
Member

Note that the Queue position of the stuck Uploads becomes duplicated in this scenario, which might be causing the inconsistent behaviour? Disconnecting+reconnecting doesn't resolve it, but restarting the application does, perhaps because all Queue position are then reset (perhaps "Can't connect" items need to be given a Null position in the Queue).

This is cosmetic, but fixed in 7f12d70

@mathiascode
Copy link
Member

With the recent improvements to the queue system, this should be doable if we simply change the status text back to "Queued" and let the queue system pick up the transfer eventually. If the user doesn't want the file anymore, they'll reject it as usual.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Development

No branches or pull requests

3 participants