Drop loop kwarg from asyncio.gather call #7
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
farmio
requested changes
May 26, 2022
mweinelt
force-pushed
the
py310-gather-drop-loop
branch
from
9deb209
to
c5440fb
Compare
|
Indeed, updated. |
|
Does anyone have an idea why the 3.7 test runner fails here? |
I'm willing to wage a guess that this is due to travis' outdated environment. Ideally the project would migrate to GitHub Actions or something else. |
Merged
|
Tests fixed in #8. |
On Python 3.10 gather does not accept the loop kwarg anymore: > res = await asyncio.gather(*requests, loop=loop, return_exceptions=True) E TypeError: gather() got an unexpected keyword argument 'loop'
mweinelt
force-pushed
the
py310-gather-drop-loop
branch
from
c5440fb
to
b359d9d
Compare
|
Rebased, so we benefit from the updated tests setup. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
On Python 3.10 gather does not accept the loop kwarg anymore:
Tested against python 3.9/3.10.