Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Run black and flake8 with pre-commit #43

Merged
merged 4 commits into from
Sep 24, 2020
Merged

Run black and flake8 with pre-commit #43

merged 4 commits into from
Sep 24, 2020

Conversation

scop
Copy link
Contributor

@scop scop commented Sep 24, 2020

Although possible, I didn't make pylint and mypy run through pre-commit because there are known issues with them and pre-commit vs virtualenvs.

@scop scop mentioned this pull request Sep 24, 2020
Merged
@nielstron nielstron changed the base branch from master to dev September 24, 2020 18:01
@nielstron
Copy link
Owner

Looks good, thanks!

@nielstron nielstron merged commit d587896 into nielstron:dev Sep 24, 2020
@scop scop deleted the pre-commit branch September 24, 2020 18:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@scop @nielstron