-
Notifications
You must be signed in to change notification settings - Fork 26
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Refactor/doc tests #44
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
neomonkeus
force-pushed
the
refactor/doc_tests
branch
from
December 6, 2017 22:41
d5125c6
to
a268726
Compare
neomonkeus
force-pushed
the
refactor/doc_tests
branch
from
January 2, 2018 19:21
a268726
to
c33ad53
Compare
neomonkeus
force-pushed
the
refactor/doc_tests
branch
from
April 5, 2018 20:13
c33ad53
to
5a78778
Compare
Renamed files to drop the name asa already convention from dir structure
neomonkeus
force-pushed
the
refactor/doc_tests
branch
from
January 10, 2019 17:08
5a78778
to
a8e1cd9
Compare
Travis automation has picked up issues with python 3.7 and some generator functions. |
I figured out the problem, my solution was this. Or surround the Example: def get_triangles(self):
"""Generator for all triangles."""
if self.faces: ...
elif self.indices_data:
it = iter(self.indices_data.indices)
try:
while True:
yield next(it), next(it), next(it)
except StopIteration:
pass |
Fixes skinning for Wildlife Park 2&3 - would scale mesh to zero. Could wrap the actual skinning in a helper function to re-use code and save some lines.
Had no attribute sub_constraint, causing import to fail due to apply_scale() being called on it.
Not tested because I didn't find one in the wild, but it has the exact same pattern found in bhkLimitedHingeConstraint, and no sub_constraint attribute is noted in the nif.xml, but the corrected ones are.
Essential PyFFI fixes for NIF import
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
@niftools/pyffi-reviewer
Overview
Convert remaining text based doctests to run using nose.
Fixes Known Issues
N\A
Documentation
Covered by existing documentation
Testing
All existing test cases passing
Manual
N\A pure automation
Automated
Full regression suite passing
Additional Information