Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Metafrost/royalties #1

Merged
merged 41 commits into from
Mar 3, 2024
Merged

Metafrost/royalties #1

merged 41 commits into from
Mar 3, 2024

Conversation

samuelvanderwaal
Copy link
Contributor

@samuelvanderwaal samuelvanderwaal commented Feb 25, 2024

To-do:

  • JS tests
  • Decode royalty extension in CLI
  • Create asset w/ Royalties extension via CLI
  • Refactor transfer logic to reduce if nesting, if possible
  • Check logic matches royalties feature in TM
  • Fix AND and OR JS deserialization implementations
  • Fix cyclic dep issue
  • Add Grouping to Bridge for Collection assets

@samuelvanderwaal samuelvanderwaal marked this pull request as draft February 26, 2024 01:39
@samuelvanderwaal samuelvanderwaal marked this pull request as ready for review March 1, 2024 09:10
* Refactor royalty types serializer

* Tweaks

* Fix array size
Copy link
Contributor

@febo febo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks very good!

@samuelvanderwaal samuelvanderwaal merged commit 0f43bde into main Mar 3, 2024
@samuelvanderwaal samuelvanderwaal deleted the metafrost/royalties branch March 3, 2024 22:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants