Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Set authority as optional signer #17

Merged
merged 6 commits into from
Mar 13, 2024
Merged

Conversation

febo
Copy link
Contributor

@febo febo commented Mar 10, 2024

This PR sets the authority as an optional signer on the create instruction. This allows a different authority than the payer to sing the create instruction when a group is being set. Note that the authority of the asset must match the authority of the group asset for the asset to be added to the group.

@febo febo marked this pull request as ready for review March 10, 2024 18:43
@febo febo marked this pull request as draft March 10, 2024 18:44
@febo
Copy link
Contributor Author

febo commented Mar 10, 2024

Currently in draft – I will write a couple of tests to exemplify the scenario where the authority needs to be a signer.

@febo febo marked this pull request as ready for review March 11, 2024 13:06
clients/js/asset/test/create.test.ts Outdated Show resolved Hide resolved
@febo febo merged commit 4df7882 into main Mar 13, 2024
16 checks passed
@febo febo deleted the febo/authority-optional-signer branch March 13, 2024 00:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants