Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add lifecycle callback #27

Merged
merged 4 commits into from
Mar 20, 2024
Merged

Add lifecycle callback #27

merged 4 commits into from
Mar 20, 2024

Conversation

febo
Copy link
Contributor

@febo febo commented Mar 19, 2024

This PR adds a lifecycle callback to all extension so the extension data is validated on creation and update. This involved:

  • Adding a *Mut struct to each extension (some of them had it already)
  • Implementing the Lifecycle trait
  • Refactored the extension builder trait

The PR also includes a fix for the CI, which had a conflict on the cache name on the CLI build.

@febo febo marked this pull request as ready for review March 20, 2024 01:18
@febo febo merged commit 58adaf3 into main Mar 20, 2024
18 checks passed
@febo febo deleted the feob/extension-lifecycle branch March 20, 2024 07:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants