Using temp files to avoid default graphs from overwriting one another #44
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Issue: Generating a number of different graphs with default settings will cause previous graphs to be overwritten by the most recently-generated one. Now, using temp file names, we avoid overwriting previously-generated graphs.
|
The issue looks legit. The proposed change is too simple. We have to think of how to remove the generated temp files. Currently, we do not care because we use fixed names and therefore do not create too much garbage.
Let me think of this issue (see the new #45) and deal with it. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue: Generating multiple graphs with default settings will cause PDFs to be generated and opened in your default PDF reader. However, the previous behavior is for the previous PDF files to be overwritten with the new one. Depending on your PDF viewer, this might be visible as multiple windows all open to the same file, that you had expected to be different.
Fix: Using unique temp files, previous PDFs will not be overwritten, so data from previous runs is preserved and any PDFs you have open will stay the way they are.