fix importing settings from Nightscout #170
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
bjornoleh
approved these changes
May 10, 2024
|
I believe Trio v0.1.0 is still doing this -- this happened to me too, today. My 2 segments of ISF (55 and 60) were imported as 9. And my target was set to 72. |
Yes, this PR has not yet been merged, so current dev still has this issue. |
dnzxy
approved these changes
May 11, 2024
|
I know this was already merged, but I tested this morning -- the error occurred when importing, using mg/dl. I applied the fix, reimported from NS and then settings were imported correctly. Thanks! |
Merged
4 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Before this PR, two settings were not imported from Nightscout correctly for me.
My 95 mg/dL target glucose got imported as 72 mg/dL (the lowest allowed)
My 58mg/dL ISF got imported as 9 mg/dL
After applying this PR and building to a fresh now simulator, my settings were imported correctly.
I then reset the simulator and installed this PR again to test with somebody else's Nightscout which uses mmol/L and confirmed target glucose and ISF did get imported correctly as well.