Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Submodule updates for Trio: OmniBLE, OmniKit #281

Merged
merged 2 commits into from
Jun 8, 2024

Conversation

marionbarker
Copy link
Contributor

These updates to the OmniBLE and OmniKit submodules address this Issue #244 (comment)

For OmniBLE there is an additional updates used by developers who need to parse logs from Loop and Trio (and iAPS). This code update makes the parser more general.

@dnzxy dnzxy added the dependencies Pull requests that update a dependency file label Jun 8, 2024
Copy link
Contributor

@dnzxy dnzxy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looked at the PRs that prompted these code changes over at OmniKit and OmniBLE; changes were good, so I approved those PRs (prior to merge), which makes this PR just a dependency update chore.

LGTM.

@bjornoleh bjornoleh linked an issue Jun 8, 2024 that may be closed by this pull request
Copy link
Contributor

@bjornoleh bjornoleh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The submodules are taken from the latest commits of OmniBLE dev and OmniKit main, and builds successfully to Xcode simulator.

LGTM!

@bjornoleh
Copy link
Contributor

Merging with two approvals.

@bjornoleh bjornoleh merged commit 2ec9fb1 into nightscout:dev Jun 8, 2024
1 check passed
This was referenced Jun 10, 2024
mountrcg pushed a commit to mountrcg/Trio that referenced this pull request Jun 15, 2024
Submodule updates for Trio: OmniBLE, OmniKit
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
dependencies Pull requests that update a dependency file
Projects
Status: Done
Development

Successfully merging this pull request may close these issues.

Critical Pod Fault 049 (0x31) Error When Resuming Insulin Delivery
3 participants