Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Dev #39

Merged
merged 23 commits into from
Mar 31, 2024
Merged

Dev #39

merged 23 commits into from
Mar 31, 2024

Conversation

bjornoleh
Copy link
Contributor

No description provided.

MikePlante1 and others added 23 commits March 6, 2024 20:31
link Discord, typo fix, change `code quality` to `open source and peer review`
Connect using G7 manager in Open-iAPS
- Replace $(DEVELOPMENT_TEAM) parsed from BUNDLE_IDENTIFIER in Config.xcconfig with ENV["TEAMID"]
- Use BUNDLE_ID instead of hard coded bundle identifier in Fastfile, inspired by Artificial-Pancreas/iAPS 6a46a2a by @Jon-b-m 
- Allows building of different instances of the app by only editing Config.xcconfig.
Update App Name and Logos
… align with Loop dev improvements, as previously added to iAPS in PR 46
- use actions/checkout@v4
- use aormsby/Fork-Sync-With-Upstream-action@v3.4.1
- comment out "Select Xcode version" step to use the default Xcode (15.0.1) in macos-13 runner

based on https://github.com/LoopKit/LoopWorkspace/pull/120/files by @dnzxy
- UPSTREAM_REPO: nightscout/Open-iAPS
- Search for and create `alive` branch by use of `${{ github.repository }}` context, instead of
`${{ github.repository_owner }}/iAPS`
- Create `alive` branch from `main` instead of `dev`
- do not run the upstream sync action on the upstream repository (owner = nightscout)
- update testflight.md with the Open-iAPS name
- Authenticate the curl API request by GH_PAT according to
https://docs.github.com/de/rest/authentication/authenticating-to-the-rest-api?apiVersion=2022-11-28#authenticating-in-a-github-actions-workflow-using-curl
Thank you @dnzxy for the hint!

This is a temporary requirement until the repositories are made public.
Allow config override file to take action from two directories up, to align with Loop and other DIY projects.
Makes the config override file in the project root take precedence if there are override files in both root and two directories up.
Config.xcconfig: #include? "../../ConfigOverride.xcconfig"
Fastlane/GH build improvements: Add sync action and keepalive action,
Get BUNDLE_IDENTIFIER from Config.xcconfig for use in Fastfile
@bjornoleh bjornoleh merged commit c346fb0 into current-oref Mar 31, 2024
@MikePlante1 MikePlante1 mentioned this pull request Apr 16, 2024
@MikePlante1 MikePlante1 mentioned this pull request May 3, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants