Update URL scheme for Open-iAPS #41
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
bjornoleh
commented
Mar 31, 2024
bjornoleh
commented
- Config.xconfig: APP_URL_SCHEME = Open-iAPS
- remove hardcoded "freeaps-x", leaving $(APP_URL_SCHEME)
- CGMType.swift: libreTransmitter: URL(string: "Open-iAPS://libre-transmitter"
- AlertEntry.swift: static let manual = "Open-iAPS"
- CarbsEntry.swift: static let manual = "Open-iAPS"
- NightscoutTreatment.swift: static let local = "Open-iAPS"
- Sources/Models/TempTarget.swift: static let manual = "Open-iAPS"
- NightscoutAPI.swift: var enteredBy = "Open-iAPS", var notes = "Open-iAPS connected"
- GarminManager.swift: connectIQ?.initialize(withUrlScheme: "Open-iAPS", uiOverrideDelegate: self)
- Config.xconfig: APP_URL_SCHEME = Open-iAPS - remove hardcoded "freeaps-x", leaving $(APP_URL_SCHEME) - CGMType.swift: libreTransmitter: URL(string: "Open-iAPS://libre-transmitter" - AlertEntry.swift: static let manual = "Open-iAPS" - CarbsEntry.swift: static let manual = "Open-iAPS" - NightscoutTreatment.swift: static let local = "Open-iAPS" - Sources/Models/TempTarget.swift: static let manual = "Open-iAPS" - NightscoutAPI.swift: var enteredBy = "Open-iAPS", var notes = "Open-iAPS connected" - GarminManager.swift: connectIQ?.initialize(withUrlScheme: "Open-iAPS", uiOverrideDelegate: self)
|
I have tested that NS entries for bolus, carbs and temp targets now have the correct "Entered by". Example for TT: Also the message when connecting to NS is verified:
Edit: |
bjornoleh
commented
Apr 1, 2024
bjornoleh
commented
Apr 1, 2024
|
Changing the base branch to feat-bundleid-versionnumber, as testing gets inconvenient now that the bundle ID is being changed in #31, and the contents of this PR is closely related to #31 . |
|
Merging this into feat-bundleid-versionnumber |
4 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.