Feat: App display name, BundleID and reset of version number #31

Sjoerd-Bo3 · 2024-03-28T10:54:04Z

BundleID changed in line with the requests:

org.nightscout.[TEAMID].openiaps

Als the version numbering reset to 0.1.0, with the initial release this should be on 1.0.0

bjornoleh · 2024-03-28T10:56:00Z

This is not complete unless also editing Fastfile. I suggest to incorporate this: #17

Edit: #17 is merged now

Sjoerd-Bo3 · 2024-03-28T10:59:08Z

This is not complete unless also editing Fastfile. I suggest to incorporate this: #17

Okay it should be based on that then, I will rebase. But I my opinion it is a seperate issue.

dnzxy · 2024-03-28T11:39:30Z

it is a seperate issue.

Not a separate issue as your changes only change the bundle ID for Xcode and that would essentially break browser build. As Bjørn has mentioned, this file needs to be changed too: ./fastlane/Fastfile
Additionally, ./fastlane/testflight.md also will need changing, so will the documentation.

Sjoerd-Bo3 · 2024-03-28T11:46:04Z

Not a separate issue as your changes only change the bundle ID for Xcode and that would essentially break browser build. As Bjørn has mentioned, this file needs to be changed too: ./fastlane/Fastfile Additionally, ./fastlane/testflight.md also will need changing, so will the documentation.

Yeah okay, I will change the docs and testflight part. But it is dependant on the fastfile change, but shouldn't be in here though right? Otherwise we need to merge these.

marionbarker · 2024-03-29T22:50:56Z

I tested this on the Mac and it almost works. The problem should have been fixed in PR #26, which has already been merged.

Tagging @avouspierre or @bjornoleh who worked that PR which missed this change in FreeAPS.xcodeproj/project.pbxproj, needed to allow PR 31 to work properly. There are too many branches . . .

Just the diffs: lines 3307 and 3328 for main and dev or 3184 and 3205 for loopkit_dev_submodules

-                               PRODUCT_BUNDLE_IDENTIFIER = ru.artpancreas.FreeAPSTests;
+                               PRODUCT_BUNDLE_IDENTIFIER = "$(BUNDLE_IDENTIFIER).FreeAPSTests";

and

-                               PRODUCT_BUNDLE_IDENTIFIER = ru.artpancreas.FreeAPSTests;
+                               PRODUCT_BUNDLE_IDENTIFIER = "$(BUNDLE_IDENTIFIER)";

Making this change was required for automatic signing to work for a Mac build with changed from PR 31.

@marionbarker

Thanks to @marionbarker for input.

PRODUCT_BUNDLE_IDENTIFIER = "$(BUNDLE_IDENTIFIER).FreeAPSTests" - Update plist keys with Open-iAPS: INFOPLIST_KEY_CFBundleDisplayName = Open-iAPS INFOPLIST_KEY_CFBundleDisplayName = "Open-iAPS WatchKit Extension"

…n Settings

bjornoleh · 2024-03-30T20:51:54Z

I tested this on the Mac and it almost works. The problem should have been fixed in PR #26, which has already been merged.

Tagging @avouspierre or @bjornoleh who worked that PR which missed this change in FreeAPS.xcodeproj/project.pbxproj, needed to allow PR 31 to work properly. There are too many branches . . .

Just the diffs: lines 3307 and 3328 for main and dev or 3184 and 3205 for loopkit_dev_submodules
-                               PRODUCT_BUNDLE_IDENTIFIER = ru.artpancreas.FreeAPSTests;
+                               PRODUCT_BUNDLE_IDENTIFIER = "$(BUNDLE_IDENTIFIER).FreeAPSTests";
and
-                               PRODUCT_BUNDLE_IDENTIFIER = ru.artpancreas.FreeAPSTests;
+                               PRODUCT_BUNDLE_IDENTIFIER = "$(BUNDLE_IDENTIFIER)";
Making this change was required for automatic signing to work for a Mac build with changed from PR 31.

This should be sorted now, as well as displaying Open-iAPS under Settings.

bjornoleh · 2024-03-30T20:56:22Z

Somehow, I do not get any matches for Open-iAPS or OiAPS when searching for the app in iOS settings, although it is listed as OiAPS.
Edit: resolved after rebooting the phone (and waiting a bit??)

marionbarker · 2024-03-31T03:41:21Z

The APP_DISPLAY_NAME = OiAPS found in Config.xconfig only shows up as the display name on the phone.
When I changed that to Open-iAPS in my local clone, the app on the phone shows up as Open-iAPS instead of OiAPS.

At first - in Apple Health - it still showed up as OiAPS, but after reboot, that showed up as Open-iAPS as well.

bjornoleh · 2024-03-31T05:58:18Z

The APP_DISPLAY_NAME = OiAPS found in Config.xconfig only shows up as the display name on the phone. When I changed that to Open-iAPS in my local clone, the app on the phone shows up as Open-iAPS instead of OiAPS.

At first - in Apple Health - it still showed up as OiAPS, but after reboot, that showed up as Open-iAPS as well.

Thanks. Does the app name show up when you search for it in iOS settings after rebooting?

I think we should change OiAPS to Open-iAPS anyways. Does it display ok under the icon?

Edit: App display name was changed to Open-iAPD in 64fb31d

- Config.xconfig: APP_URL_SCHEME = Open-iAPS - remove hardcoded "freeaps-x", leaving $(APP_URL_SCHEME) - CGMType.swift: libreTransmitter: URL(string: "Open-iAPS://libre-transmitter" - AlertEntry.swift: static let manual = "Open-iAPS" - CarbsEntry.swift: static let manual = "Open-iAPS" - NightscoutTreatment.swift: static let local = "Open-iAPS" - Sources/Models/TempTarget.swift: static let manual = "Open-iAPS" - NightscoutAPI.swift: var enteredBy = "Open-iAPS", var notes = "Open-iAPS connected" - GarminManager.swift: connectIQ?.initialize(withUrlScheme: "Open-iAPS", uiOverrideDelegate: self)

Changing the app display name from `OiAPS` (as introduced in #19) to `Open-iAPS`, after having discussed this in Discord.

bjornoleh

Edit: lets include #41 here as well

Dev

Update URL scheme for Open-iAPS

bjornoleh

Now this PR is complete, please merge into dev!

Sjoerd-Bo3

LGTM 🚀 Let the Merge commence!

Sjoerd-Bo3 added 2 commits March 28, 2024 11:49

feat: changed bundle identifier to nightscout openiaps naming

44b55ca

feat(versionning): reset the version numbering back to 0.1.0

dd98ebe

Sjoerd-Bo3 requested review from bjornoleh and MikePlante1 March 28, 2024 10:54

Sjoerd-Bo3 changed the base branch from main to dev March 28, 2024 10:54

bjornoleh mentioned this pull request Mar 30, 2024

Get BUNDLE_IDENTIFIER from Config.xcconfig for use in Fastfile #17

Merged

bjornoleh and others added 3 commits March 30, 2024 19:51

testflight.md: Use org.nightscout.TEAMID.openiaps in App Store Connect

a272c39

Thanks to @marionbarker for input.

Use BUNDLE_IDENTIFIER for signing of FreeAPSTests target

56f341a

PRODUCT_BUNDLE_IDENTIFIER = "$(BUNDLE_IDENTIFIER).FreeAPSTests" - Update plist keys with Open-iAPS: INFOPLIST_KEY_CFBundleDisplayName = Open-iAPS INFOPLIST_KEY_CFBundleDisplayName = "Open-iAPS WatchKit Extension"

SettingsRootView.swift: Display Open-iAPS along with version number i…

3bb5dab

…n Settings

bjornoleh and others added 2 commits March 31, 2024 22:42

Config.xcconfig: APP_DISPLAY_NAME = Open-iAPS

64fb31d

Changing the app display name from `OiAPS` (as introduced in #19) to `Open-iAPS`, after having discussed this in Discord.

bjornoleh changed the title ~~Feat: BundleID and reset of versionnumber~~ Feat: App display name, BundleID and reset of version number Apr 1, 2024

bjornoleh approved these changes Apr 1, 2024

View reviewed changes

bjornoleh mentioned this pull request Apr 1, 2024

Update URL scheme for Open-iAPS #41

Merged

bjornoleh added 2 commits April 1, 2024 23:13

Merge pull request #43 from nightscout/dev

8f4c2df

Dev

Merge pull request #41 from nightscout/urlScheme

89d45e8

Update URL scheme for Open-iAPS

bjornoleh self-requested a review April 1, 2024 21:21

bjornoleh approved these changes Apr 1, 2024

View reviewed changes

MikePlante1 approved these changes Apr 1, 2024

View reviewed changes

Sjoerd-Bo3 commented Apr 2, 2024

View reviewed changes

Sjoerd-Bo3 merged commit 8cd27c3 into dev Apr 2, 2024

Sjoerd-Bo3 deleted the feat-bundleid-versionnumber branch April 2, 2024 19:06

bjornoleh mentioned this pull request Apr 4, 2024

Trio Release 0.2.0 #2

Merged

MikePlante1 mentioned this pull request Jun 16, 2024

(Draft) Merge dev into main MikePlante1/Trio#5

Closed

4 tasks

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Feat: App display name, BundleID and reset of version number #31

Feat: App display name, BundleID and reset of version number #31

Sjoerd-Bo3 commented Mar 28, 2024 •

edited

Loading

bjornoleh commented Mar 28, 2024 •

edited

Loading

Sjoerd-Bo3 commented Mar 28, 2024

dnzxy commented Mar 28, 2024 •

edited

Loading

Sjoerd-Bo3 commented Mar 28, 2024

marionbarker commented Mar 29, 2024

bjornoleh commented Mar 30, 2024 •

edited

Loading

bjornoleh commented Mar 30, 2024 •

edited

Loading

marionbarker commented Mar 31, 2024

bjornoleh commented Mar 31, 2024 •

edited

Loading

bjornoleh left a comment •

edited

Loading

bjornoleh left a comment

Sjoerd-Bo3 left a comment •

edited

Loading

Feat: App display name, BundleID and reset of version number #31

Feat: App display name, BundleID and reset of version number #31

Conversation

Sjoerd-Bo3 commented Mar 28, 2024 • edited Loading

bjornoleh commented Mar 28, 2024 • edited Loading

Sjoerd-Bo3 commented Mar 28, 2024

dnzxy commented Mar 28, 2024 • edited Loading

Sjoerd-Bo3 commented Mar 28, 2024

marionbarker commented Mar 29, 2024

bjornoleh commented Mar 30, 2024 • edited Loading

bjornoleh commented Mar 30, 2024 • edited Loading

marionbarker commented Mar 31, 2024

bjornoleh commented Mar 31, 2024 • edited Loading

bjornoleh left a comment • edited Loading

Choose a reason for hiding this comment

bjornoleh left a comment

Choose a reason for hiding this comment

Sjoerd-Bo3 left a comment • edited Loading

Choose a reason for hiding this comment

Sjoerd-Bo3 commented Mar 28, 2024 •

edited

Loading

bjornoleh commented Mar 28, 2024 •

edited

Loading

dnzxy commented Mar 28, 2024 •

edited

Loading

bjornoleh commented Mar 30, 2024 •

edited

Loading

bjornoleh commented Mar 30, 2024 •

edited

Loading

bjornoleh commented Mar 31, 2024 •

edited

Loading

bjornoleh left a comment •

edited

Loading

Sjoerd-Bo3 left a comment •

edited

Loading