Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix activityContrib #2283

Merged
merged 2 commits into from
Dec 2, 2016
Merged

Fix activityContrib #2283

merged 2 commits into from
Dec 2, 2016

Conversation

warstar2187
Copy link
Contributor

This fixes an incorrect insulin activity calculation for DIA <> 3h, which would result in negative insulin activity (and positive BGI) at the tail end of the DIA for DIA < 3h, and erroneously high activity (and too-low BGI) for DIA > 3h. Discussion at https://gitter.im/MilosKozak/AndroidAPS?at=583cd6c116207f7b0eb97fa2

Before fix.
image

After fix.
image

@jasoncalabrese jasoncalabrese merged commit 0de7ff4 into nightscout:dev Dec 2, 2016
@jasoncalabrese jasoncalabrese added this to the 0.9.2 milestone Dec 2, 2016
@jasoncalabrese
Copy link
Member

Thanks for tracking this bug down in all the various repos

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants