Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

remove python and python-software-properties from setup.sh #3683

Closed
wants to merge 1 commit into from

Conversation

PieterGit
Copy link
Contributor

@PieterGit PieterGit commented Jul 10, 2018

As far as I see in the current codebase there are no references to python.

Should be tested with reinstall on clean pi3 install.

Fixes #3577

As far as I see in the current codebase there are no references to python. Should be tested with reinstall on clean pi3 install.
@PieterGit PieterGit added this to the 0.10.3 milestone Jul 10, 2018
@PieterGit PieterGit modified the milestones: 0.10.3, 0.11.0 Aug 5, 2018
@viq
Copy link
Contributor

viq commented Dec 9, 2018

Do you want specifically tests on pi/raspian/debian, or any environment without python would work for you?

@PieterGit
Copy link
Contributor Author

@viq The issue was with RPI3, see #3577 . I can't find any python dependencies, except for one Travis script, but that won't harm normal install by users. Because I remove python scripts I think any debian/ubuntu based install without python install should be able to test this.

@PieterGit
Copy link
Contributor Author

This PR has been integrated with the https://github.com/nightscout/cgm-remote-monitor/tree/needs_testing
branch. Please test that branch and report at this issue or at #4169

@PieterGit PieterGit reopened this Dec 31, 2018
@PieterGit
Copy link
Contributor Author

This PR has been tested as part of the need_testing branch of #4169
@blocklist_twitter @balshor @sulkaharo @jpcunningh @unsoluble @veryfancy @balshor @tynbendad have run this PR for a week.
No negative stuff popped up. Gitter link: https://gitter.im/nightscout/public?at=5c2f33d12863d8612bd78eb0

Unfortuately probably nobody tested this PR exactly, but from a code perspective this should work. Needs to be test on a raspberry pi installation but there is currently no volunteer to do so.
If you encounter success or failure with this PR, please reopen the issue and share your findings.

Closing PR, will be merged with #4169

@PieterGit PieterGit closed this Jan 5, 2019
@PieterGit PieterGit deleted the 201807_python branch September 3, 2020 18:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants