Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bundled features for 0.11 that need to be tested and approved before being merged #4169

Merged
merged 146 commits into from
Jan 5, 2019

Conversation

PieterGit
Copy link
Contributor

@PieterGit PieterGit commented Dec 31, 2018

PR with several PR's that need testing. Most of these issue have been reviewed, but have not gotten enough test by others. Because we don't want to merge PR's that have not been tested enough, I bundled these issues.

This PR includes issues labeled needs_testing and are milestoned for the 0.11 release. See
https://github.com/nightscout/cgm-remote-monitor/issues?utf8=%E2%9C%93&q=is%3Aopen+label%3A%22needs+testing%22++milestone%3A%220.11.0%22

image

Later: #4175 (upgrade share2nightscout-bridge to 0.2.0) was also added to this branch.

This includes:

lixgbg and others added 30 commits March 10, 2018 16:27
Dev update from nightscout
New branch dev -> loopalyzer-dev, cloned to Mac, edited index.js and pushing.
Update with latest dev; IOB/COB from NS client util
* Skipping Loopalyzer unless it is the selected tab
* Showing message if more than one week duration selected
Added fill-in using carb and insulin treatments to avoid gaps in graphs
@nightscout nightscout deleted a comment Dec 31, 2018
@nightscout nightscout deleted a comment Jan 1, 2019
@PieterGit
Copy link
Contributor Author

@nightscout nightscout deleted a comment Jan 1, 2019
@PieterGit PieterGit mentioned this pull request Jan 1, 2019
"traverse": "^0.6.6",
"uglify-js": "^3.4.9",
"uuid": "^3.2.1"
"uglify-js": "^3.4.9"
},
"devDependencies": {
"benv": "^3.3.0",
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I had to add "jsdom": "~11.11.0",.

benv brakes with 11.12 or later versions of jsdom.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@jpcunningh great find. I didn't understand why my tests did not run under Windows, but the Travis builds were fine. What platform do you use? I think we should try to seek for an alternative for benv because is does not seem to be maintained.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I now noticed that Travis didn't work either. @sulkaharo do you have any idea why the error was not propagated to a failed build, see e.g. https://travis-ci.org/nightscout/cgm-remote-monitor/jobs/474055158

Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@PieterGit, I'm running Ubuntu 18.04.

Jeremy Cunningham and others added 3 commits January 1, 2019 15:50
Use npm released version instead of wip/generalize branch. This version will also make sure Nightscout won't crash if Dexcom servers are down.
@jpcunningh
Copy link
Collaborator

@PieterGit, other than the issue noted above, I've been running this branch for 3 days without any issues.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants