DialogFlow APIv2 Integration (GoogleHome) - dev #4035

mdomox · 2018-10-31T07:16:01Z

No description provided.

udate

Revert "Update language.js" (nightscout#3406)

Dev

Release/0.10.3

0.10.3

German language change. Name too long, please switch back to BWP

Create issue templates for NS repo

sulkaharo · 2018-11-09T10:43:23Z

lib/plugins/basalprofile.js

+      , intentHandler: googleHomeCurrentBasalhandler
+    }]
+  };
+


What API call changes are needed to have this live in the Home plugin? basalprofile.js should only contain basalprofile code.

sulkaharo · 2018-11-09T10:44:11Z

lib/plugins/iob.js

+      , slots: ['iob', 'insulin on board', 'insulin']
+      , intentHandler: googleHomeIOBIntentHandler
+    }]
+  };


Same here let's aim to restructure both Home and Alexa so the IOB reporting code is in the plugin, not in iob.js

Alternatively, would it be possible to add a single method that output a string for speech and reuse that in both Home and Alexa? That'd maybe be the cleanest solution?

sulkaharo · 2018-11-09T10:45:11Z

lib/server/bootevent.js

+
+    if (env.settings.isEnabled('googlehome')) {
+      ctx.googleHome = require('../plugins/googlehome')(env, ctx);
+    }

    next( );
  }


@PieterGit let's try to figure out if there's a way to reduce plugin-specific code in this section

sulkaharo · 2018-11-09T10:46:58Z

lib/plugins/openaps.js

+      intent: 'LastLoop'
+      , intentHandler: googleHomeLastLoopHandler
+    }]
+  };



And same here - Home and Alexa code for creating the speech user interface should be in the plugin itself. What'd be acceptable for this file is a generic API method that returns a string for speech, which is reused in both Home and Alexa speech implementations, but custom method for both adds a lot of maintenance burden

PieterGit · 2018-11-16T18:48:29Z

@mdomox can you fix @sulkaharo requested changes in the coming days or weeks. These changes should be made before the feature freeze for the 0.11 release. I'm thinking of postponing the freeze to beginning of december, so that we can release 0.11 before xmas.

Perhaps @rickfriele can give you some help. The issues raised by @sulkaharo must be resolved before we can merge this to dev. I also would like another Google Home user to confirm it works after you made the changes.

mdomox · 2018-11-24T23:36:59Z

@mdomox can you fix @sulkaharo requested changes in the coming days or weeks. These changes should be made before the feature freeze for the 0.11 release. I'm thinking of postponing the freeze to beginning of december, so that we can release 0.11 before xmas.

Perhaps @rickfriele can give you some help. The issues raised by @sulkaharo must be resolved before we can merge this to dev. I also would like another Google Home user to confirm it works after you made the changes.

The issues raised are common with Alexa code. As I understood a restructure is needed. I will try, but I am not 100% confident I can manage it in the timeframe required (I am new to this ). Is there documentation regarding all the variables, objects and functions declared in this project? @PieterGit

This is a DialogFlow integration. It can interface to a number of endpoints (Telegram, Viber, Skype, Facebook Messenger, Siri, Google Assistant). GoogleHome in fact, is just another Google Assistant player (as your WearOS smartwatch and Android phone).

RalfCGM · 2018-11-27T22:33:31Z

Really can't help with programming, but would like to try to help testing with Google assistant. I don't quite understand if there some code ready to be tested, but if somebody could confirm and help with merging this pull request in my ns, I'm all in.

PieterGit · 2018-12-06T22:27:40Z

@mdomox I postponed this to 0.12 release. This needs better integration. Please ask @sulkaharo for help if you need help. See https://gitter.im/nightscout/public?at=5c093bdf178d7860a194d359

PieterGit · 2019-01-06T00:08:17Z

@mdomox can you give an update if you have time to work on better Google Home (and maybe also Alexa ) integration? See also this discussion which is relevant for Google Home integration as well: #4168 (comment)

mdomox · 2019-01-06T11:24:26Z

@mdomox can you give an update if you have time to work on better Google Home (and maybe also Alexa ) integration? See also this discussion which is relevant for Google Home integration as well: #4168 (comment)
@PieterGit I am not sure this can be done, since dialogflow integration relies on Google's speech API. https://dialogflow.com/docs/reference/api-v2/rest/v2/projects.agent.intents

mdomox · 2019-01-06T11:51:35Z

@mdomox can you give an update if you have time to work on better Google Home (and maybe also Alexa ) integration? See also this discussion which is relevant for Google Home integration as well: #4168 (comment)
@PieterGit I am not sure this can be done, since dialogflow integration relies on Google's speech API. https://dialogflow.com/docs/reference/api-v2/rest/v2/projects.agent.intents

@PieterGit , moreover, now it runs independently, having the speech plugin disabled, since it constantly produces output on every new BG value (something that is not necessary or even annoying). The current implementation is not intrusive, meaning that it does not produce output unless called by the user.

PieterGit

@mdomox I did a code review. Thanks for making it more run independently. I found the following issues with this PR:

There are two codacy issues open on: https://app.codacy.com/app/Nightscout/cgm-remote-monitor/pullRequest?prid=2467222

lib/api/googlehome/index.js
line 10: 'translate' is assigned a value but never used. (no-unused-vars)
var translate = ctx.language.translate;
lib/plugins/googlehome.js
line 2: 'ctx' is defined but never used. (no-unused-vars)

can't you move the intentHandlers to lib/plugins/googlehome.js somehow, e.g. here
https://github.com/nightscout/cgm-remote-monitor/pull/4035/files#diff-5f9a8d56c561357217c992f218e4a7c7R12
you still have quite some plugin specific changes to other core plugins, these should not be added in the core plugin but inside the google home plugin. Your plugin should not touch these files:

lib/plugins/basalprofile.js
lib/plugins/cob.js
lib/plugins/iob.js
lib/plugins/openaps.js

See https://github.com/nightscout/cgm-remote-monitor/pull/4035/files for details.

Can you add unit tests for the plugin?
Can you add swagger docs for the /googlehome api?

mdomox · 2019-02-20T00:06:36Z

@mdomox I did a code review. Thanks for making it more run independently. I found the following issues with this PR:

There are two codacy issues open on: https://app.codacy.com/app/Nightscout/cgm-remote-monitor/pullRequest?prid=2467222
lib/api/googlehome/index.js
line 10: 'translate' is assigned a value but never used. (no-unused-vars)
var translate = ctx.language.translate;
lib/plugins/googlehome.js
line 2: 'ctx' is defined but never used. (no-unused-vars)
can't you move the intentHandlers to lib/plugins/googlehome.js somehow, e.g. here
https://github.com/nightscout/cgm-remote-monitor/pull/4035/files#diff-5f9a8d56c561357217c992f218e4a7c7R12
you still have quite some plugin specific changes to other core plugins, these should not be added in the core plugin but inside the google home plugin. Your plugin should not touch these files:
lib/plugins/basalprofile.js
lib/plugins/cob.js
lib/plugins/iob.js
lib/plugins/openaps.js
See https://github.com/nightscout/cgm-remote-monitor/pull/4035/files for details.

Can you add unit tests for the plugin?

Can you add swagger docs for the /googlehome api?

@PieterGit
1st comment : this is work in progress in an efort to use ctx translations. Will be removed-cleaned.

2nd comment: intentHandlers in those core plugins already exist for Alexa . Why not for DialogFlow? Why is this a show-stopper?

3rd comment: How is this done? Is there a documentation on how to perform those tests?

4rd comment: A doc is in the /doc folder. I wil review it and maybe update it.

jamieowendexcom · 2019-04-27T07:31:50Z

I have tested the mdomox googlehome on Dialogflow and my Googlehome.
All working fine and no issues so far.
Thanks to @mdomox for creating the code.

jamieowendexcom · 2019-07-21T10:10:12Z

Are we any closer to getting this merged into the master?

sulkaharo · 2019-07-21T11:00:20Z

Probably not, given lack of activity in the last few months to address the improvement requests above

nielsmaerten · 2019-07-21T12:02:21Z

For what it's worth: I may have an alternative to this.
I've been working on my own Google Assistant + Nightscout integration for a few months now:
Nightscout Status
At time of writing, around 200 people are using it daily and it's pretty reliable.

I don't mean to diminish the great work @mdomox has been doing and I realize this is not a full alternative. There will always be people who prefer to set up their own DialogFlow Actions. But for those of us who don't feel comfortable doing that, I thought a SaaS might be useful.
(Kinda like running Autotune yourself vs. AutotuneWeb.)

inventor96 · 2019-09-06T01:49:13Z

@sulkaharo @PieterGit I'm willing to take a stab at updating this PR (as I have time) to resolve the issues brought up. I'm a full-stack web developer, but unfortunately Node is not a platform I have experience with, so any pointers you can give to help me get started would be great!

PieterGit · 2019-10-18T13:58:42Z

Closing this PR. It will be integrated with the product with #4980

mdomox and others added 30 commits March 23, 2018 22:13

Merge pull request #1 from nightscout/master

7f3ab74

udate

Merge pull request #2 from nightscout/master

1b7f56a

Revert "Update language.js" (nightscout#3406)

Merge pull request #3 from nightscout/dev

051af65

Dev

Merge pull request #6 from nightscout/dev

1b09851

Dev

Greek language update

5da1217

Rename boluscalc.js to boluscalc-----.js

736fa70

Add files via upload

3d15c6b

Merge pull request nightscout#3704 from nightscout/release/0.10.3

7c272ec

Release/0.10.3

Tag matafiles with 0.10.3-master-20180805

b3f7d65

Merge pull request #9 from nightscout/master

b632833

0.10.3

Fixes the site for iOS 9 and older

ca3f518

Name too long, please switch back to BWP

5523622

Merge pull request nightscout#3839 from viderehh/patch-1

8a23db9

German language change. Name too long, please switch back to BWP

Create issue templates for NS repo

fa769b5

Merge pull request nightscout#3970 from nightscout/danamlewis-patch-1

b2b8aad

Create issue templates for NS repo

Create googlehome.js

39382aa

Delete googlehome.js

16a55c6

Create googlehome.js

6e8a9b9

Create index.js

6d87b33

Update index.js

7ab3c27

Update bootevent.js

f590a92

Update iob.js

0bd9731

Update basalprofile.js

542e2e9

Update bootevent.js

dd6c0b6

Update cob.js

f0f601b

Update cob.js

2a94037

Update cob.js

be26a15

Update openaps.js

c4fa77d

Update cob.js

a8e7d26

Update googlehome.js

6ecb5a2

sulkaharo reviewed Nov 9, 2018

View reviewed changes

PieterGit added the speech-googlehome label Nov 16, 2018

PieterGit modified the milestones: 0.11.0, 0.12.0 Dec 6, 2018

PieterGit added needs testing help wanted labels Dec 6, 2018

PieterGit mentioned this pull request Dec 12, 2018

Alexa metric synonyms #4040

Closed

PieterGit mentioned this pull request Jan 5, 2019

Add "Blood Sugar" metric/invocation to Alexa Plugin #4168

Closed

PieterGit requested changes Jan 6, 2019

View reviewed changes

inventor96 referenced this pull request in inventor96/cgm-remote-monitor Sep 6, 2019

Copied work done by mdomox

202402f

inventor96 mentioned this pull request Sep 12, 2019

Update Alexa integration and add Google Home support #4980

Merged

PieterGit closed this Oct 18, 2019

PieterGit removed this from the 0.12.0 milestone Oct 18, 2019

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

DialogFlow APIv2 Integration (GoogleHome) - dev #4035

DialogFlow APIv2 Integration (GoogleHome) - dev #4035

mdomox commented Oct 31, 2018

sulkaharo Nov 9, 2018

sulkaharo Nov 9, 2018

sulkaharo Nov 9, 2018

sulkaharo Nov 9, 2018

sulkaharo Nov 9, 2018

PieterGit commented Nov 16, 2018 •

edited

Loading

mdomox commented Nov 24, 2018 •

edited

Loading

RalfCGM commented Nov 27, 2018

PieterGit commented Dec 6, 2018

PieterGit commented Jan 6, 2019

mdomox commented Jan 6, 2019

mdomox commented Jan 6, 2019

PieterGit left a comment •

edited

Loading

mdomox commented Feb 20, 2019 •

edited

Loading

jamieowendexcom commented Apr 27, 2019

jamieowendexcom commented Jul 21, 2019

sulkaharo commented Jul 21, 2019

nielsmaerten commented Jul 21, 2019

inventor96 commented Sep 6, 2019

PieterGit commented Oct 18, 2019

DialogFlow APIv2 Integration (GoogleHome) - dev #4035

DialogFlow APIv2 Integration (GoogleHome) - dev #4035

Conversation

mdomox commented Oct 31, 2018

sulkaharo Nov 9, 2018

Choose a reason for hiding this comment

sulkaharo Nov 9, 2018

Choose a reason for hiding this comment

sulkaharo Nov 9, 2018

Choose a reason for hiding this comment

sulkaharo Nov 9, 2018

Choose a reason for hiding this comment

sulkaharo Nov 9, 2018

Choose a reason for hiding this comment

PieterGit commented Nov 16, 2018 • edited Loading

mdomox commented Nov 24, 2018 • edited Loading

RalfCGM commented Nov 27, 2018

PieterGit commented Dec 6, 2018

PieterGit commented Jan 6, 2019

mdomox commented Jan 6, 2019

mdomox commented Jan 6, 2019

PieterGit left a comment • edited Loading

Choose a reason for hiding this comment

mdomox commented Feb 20, 2019 • edited Loading

jamieowendexcom commented Apr 27, 2019

jamieowendexcom commented Jul 21, 2019

sulkaharo commented Jul 21, 2019

nielsmaerten commented Jul 21, 2019

inventor96 commented Sep 6, 2019

PieterGit commented Oct 18, 2019

PieterGit commented Nov 16, 2018 •

edited

Loading

mdomox commented Nov 24, 2018 •

edited

Loading

PieterGit left a comment •

edited

Loading

mdomox commented Feb 20, 2019 •

edited

Loading