Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Alexa metric synonyms #4040

Closed
wants to merge 11 commits into from
Closed

Conversation

tanja3981
Copy link
Contributor

Currently the list of metrics could only be asked in english. As you can now defined synonyms in the amazon developer portal, this can be used for translated/costumized terms.

@PieterGit
Copy link
Contributor

@tanja3981 Can you check the CI build errrors?
@francesc0-cgm (or other Alexa users) Can you help test this PR?

@francesc0-cgm
Copy link

I am doing @PieterGit
All utterances in italian works now. I still have problems with metrics but i am trying with the help of @tanja3981 to get them working

@tanja3981
Copy link
Contributor Author

@PieterGit Honestly I have no clue why the build failed, as I rebased on dev directly before adding that pull request and my branch was built without that problem.
Also the error doesn't explain anything to me. Could you have a look and check what certifcate problem could be caused by? Thanks in advance.

@tanja3981
Copy link
Contributor Author

@winni67 If you have the time, it would be great if you could test. Please note that I updated the Readme regarding how to setup the skill (-> synonyms) in amazons developer portal.

@PieterGit PieterGit added this to the 0.11.0 milestone Nov 3, 2018
@francesc0-cgm
Copy link

As i reported in my other pull request PR of @tanja3981 is fully working. Only loop status is still in english

@francesc0-cgm
Copy link

Now loop forecast is working. As I told in my pull request the translation of value in loop.js has still words"between" and "and" that are still in English

@nightscout nightscout deleted a comment Nov 8, 2018
@tanja3981
Copy link
Contributor Author

@PieterGit Will this be pulled into upcoming release?
The build errors are gone since travis rebuilt.

@PieterGit
Copy link
Contributor

@tanja3981 The Alexa plugin is not separated well enough from other core files and other plugins. This is the reason why we postponed the Google Home plugin integration to Nightscout 0.12 release, see
#4035

Problem with the Alexa is, that it has been merged with Nightscout 0.10.x .

@jasoncalabrese @sulkaharo Can you please join this discussion and I propose to set a minimum of improvements to the Alexa plugin in order to merge this PR with 0.11. Thoughts?

@tanja3981 Minor issue. Please correct the conflicting lib/plugins/alexa-plugin.md

@PieterGit
Copy link
Contributor

@tanja3981 @francesc0-cgm Alexa support will not be improved in 0.11 because the Alexa code really needs to be re-organized to be maintainable. See #4168 (comment) for some more details.

@PieterGit PieterGit modified the milestones: 0.11.0, 0.12.0 Jan 5, 2019
@nightscout nightscout deleted a comment Mar 6, 2019
@tanja3981
Copy link
Contributor Author

@PieterGit Regarding your comment from Jan 6, I volunteer for the maintenance of the current version of the alexa plugin.
However, I still don't really understand the plan how the alexa plugin will be refactored, so I would leave the question about wether I'm able to develop it further and maintain it open. ;-)

@nightscout nightscout deleted a comment Jul 28, 2019
@nightscout nightscout deleted a comment Jul 28, 2019
@PieterGit PieterGit removed this from the 0.12.0 milestone Oct 20, 2019
@PieterGit
Copy link
Contributor

@tanja3981 Is this PR still relevant?

Please have a look at @inventor96 work on #4980

Closing PR. Please reopen if this can be implemented in a generic and maintainable way.

@PieterGit PieterGit closed this Oct 20, 2019
@inventor96
Copy link
Contributor

@tanja3981 @PieterGit I didn't look much at this PR before I started working on #4980, but it looks like @tanja3981 and I had similar ideas on how to improve the Alexa plugin configuration! There are still a few things that could be applicable if @tanja3981 wants to add to #4980 or create a new PR.

@tanja3981
Copy link
Contributor Author

@inventor96 @PieterGit I will have a look at this during the next few days and will also do some testing!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants