-
Notifications
You must be signed in to change notification settings - Fork 71.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Alexa metric synonyms #4040
Alexa metric synonyms #4040
Conversation
@tanja3981 Can you check the CI build errrors? |
I am doing @PieterGit |
@PieterGit Honestly I have no clue why the build failed, as I rebased on dev directly before adding that pull request and my branch was built without that problem. |
@winni67 If you have the time, it would be great if you could test. Please note that I updated the Readme regarding how to setup the skill (-> synonyms) in amazons developer portal. |
As i reported in my other pull request PR of @tanja3981 is fully working. Only loop status is still in english |
Now loop forecast is working. As I told in my pull request the translation of |
@PieterGit Will this be pulled into upcoming release? |
@tanja3981 The Alexa plugin is not separated well enough from other core files and other plugins. This is the reason why we postponed the Google Home plugin integration to Nightscout 0.12 release, see Problem with the Alexa is, that it has been merged with Nightscout 0.10.x . @jasoncalabrese @sulkaharo Can you please join this discussion and I propose to set a minimum of improvements to the Alexa plugin in order to merge this PR with 0.11. Thoughts? @tanja3981 Minor issue. Please correct the conflicting |
@tanja3981 @francesc0-cgm Alexa support will not be improved in 0.11 because the Alexa code really needs to be re-organized to be maintainable. See #4168 (comment) for some more details. |
@PieterGit Regarding your comment from Jan 6, I volunteer for the maintenance of the current version of the alexa plugin. |
/improved error message for missing loop data
c1579a5
to
b55701d
Compare
Release Nightscout 0.12.4
# Conflicts: # npm-shrinkwrap.json
@tanja3981 Is this PR still relevant? Please have a look at @inventor96 work on #4980 Closing PR. Please reopen if this can be implemented in a generic and maintainable way. |
@tanja3981 @PieterGit I didn't look much at this PR before I started working on #4980, but it looks like @tanja3981 and I had similar ideas on how to improve the Alexa plugin configuration! There are still a few things that could be applicable if @tanja3981 wants to add to #4980 or create a new PR. |
@inventor96 @PieterGit I will have a look at this during the next few days and will also do some testing! |
Currently the list of metrics could only be asked in english. As you can now defined synonyms in the amazon developer portal, this can be used for translated/costumized terms.