Add an option to enable IOB in the mainline #452
Conversation
1 similar comment
|
Need to test this on azure, and make sure the bundle can be written, etc |
|
|
||
| if (!treatments) return {}; | ||
|
|
||
| if (typeof profile === 'undefined') { |
There was a problem hiding this comment.
Just curious, is this any different from if (profile === undefined) { (which is more readable)?
|
Trying out a new pill based display for the BG delta and IOB, these don't get the strikethrough style in retro mode.
|
|
I like that… looks really good. One thing I noticed with the delta and IOB below BG and trend… the straight down arrow clips IOB in the older style. Not sure if it happens with your new pill design.
|
|
|
|
Hi Jason, you can separate them a thread? Thanks Matteo |
|
|
|
....with the oblique arrow are lowered. |
|
Hey Jason, I like the look of the pills. It really cleans up the interface. For my eyes, the grey on black colors and small fonts don't provide a lot of contrast. I have to look harder at the data to read it vs the current green / yellow / red on black. Would white on black look out of place? Jim
|
|
I was thinking the exact same thing Jim
|
|
Maybe a brighter grey? So not fully white? Icons might be good too, but then we have to move to fixed font sizes. I want to be able to plug in new types of data really easy. |
|
How does this look @ELUTE and @jasoncalabrese? I changed the pill background color to #bdbdbd but left the font color the same grey. it gives a little more contrast without looking too out of place. Maybe you have a better idea.
|
|
@jimsiff 👍 |
|
Looks good. We should probably use the same grey for the value in the pill too. Should we replace the other grey? Clock, time ago, BG (retro and default theme), etc. |
|
Sounds good. I do think the brighter grey pops more against the black... I'd like to see what it looks like with clock, time ago, BG, etc using that. I hope it doesn't kill the effectiveness of Night mode. |
|
It does look like the straight down trend bleeds into the pill. It's so hard to juggle everything with % fonts.
|
|
@jimsiff @jasoncalabrese |
|
Hi everyone, you can not keep a new display based pill and place as it was put by wip / IOB -COB have a screen cleaner ? what do you say @scottleibrand |
|
|
|
@francescaneri, trying to fit the IOB/COB into the title has been a problem. That layout is really fragile, screws up the click location of the toolbar, and runs into the title. |
|
I'm going to merge this to dev and start getting it integrated with everything else |
Add an option to enable IOB in the mainline
Like the Care Portal and Raw Data this feature will need to be enabled using the
ENABLEenv var. For example:ENABLE="careportal rawbg iob"This will use a treatment profile or default to a DIA of 3 hours. A UI for setting the treatment profile is begin working on with #439
This also make IOB available to the pebble endpoint