Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add: browser flag #18

Merged
merged 16 commits into from
Jun 17, 2022
Merged

Conversation

vaibhavsingh97
Copy link
Member

@vaibhavsingh97 vaibhavsingh97 commented Jun 13, 2022

Fixes: #12

  • Added suggestion if user had passed wrong arguments.

image

  • Added --browser flag will enable the user to pass the browser they wanted to add beforehand.
    Usage:
    npm init nightwatch -- --browser chrome --browser firefox
    # with alias
    npm init nightwatch -- -b chrome -b firefox
    # with yes flag and alias
    npm init nightwatch -- --yes -b chrome -b firefox

Packages Added:

  • Minimist for better package for argument parsing.

@vaibhavsingh97 vaibhavsingh97 marked this pull request as ready for review June 14, 2022 14:45
src/constants.ts Outdated Show resolved Hide resolved
src/index.ts Outdated Show resolved Hide resolved
src/index.ts Outdated Show resolved Hide resolved
src/index.ts Outdated Show resolved Hide resolved
src/init.ts Outdated Show resolved Hide resolved
@garg3133
Copy link
Member

Since to pass multiple browsers in argument, we need to write --browser multiple times (--browser chrome --browser edge) which is long, I think we should also have an alias for --browser. What about -b (-b chrome -b edge)?

@garg3133 garg3133 merged commit fa4a03a into nightwatchjs:main Jun 17, 2022
@vaibhavsingh97 vaibhavsingh97 deleted the feat/add-browser-flag branch June 17, 2022 14:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
No open projects
Status: Done
Development

Successfully merging this pull request may close these issues.

[Enhancement] --browser flag to pass different browsers
2 participants