Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added documentation for Install application from APK #31

Merged

Conversation

SanjayDevTech
Copy link
Contributor

For #20

Copy link
Member

@garg3133 garg3133 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The format looks good overall. Suggested a few changes.

docs/Installing-an-application-from-APK.md Outdated Show resolved Hide resolved
docs/Installing-an-application-from-APK.md Outdated Show resolved Hide resolved
docs/Installing-an-application-from-APK.md Outdated Show resolved Hide resolved
docs/Installing-an-application-from-APK.md Outdated Show resolved Hide resolved
docs/Installing-an-application-from-APK.md Outdated Show resolved Hide resolved
docs/Installing-an-application-from-APK.md Outdated Show resolved Hide resolved
@SanjayDevTech
Copy link
Contributor Author

Tagging you @garg3133 , in case if you didn't received the notification for Review request.
I have made the requested changes kindly have a look. Thanks

@garg3133
Copy link
Member

garg3133 commented Mar 6, 2024

This looks really good! Thanks a lot @SanjayDevTech for this PR, and sorry for the delay in reviewing it.

Added a few changes myself, mostly to the ADB section, to make it more clear.

Thanks again!

@garg3133 garg3133 merged commit b4349cd into nightwatchjs:main Mar 6, 2024
2 checks passed
@SanjayDevTech
Copy link
Contributor Author

Thanks @garg3133

@SanjayDevTech SanjayDevTech deleted the sanjaydevtech/docs/adb-install-apk branch March 28, 2024 04:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants