Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

build(@vitejs/plugin-react): bump to v4 #5

Merged
merged 1 commit into from
Sep 15, 2023
Merged

build(@vitejs/plugin-react): bump to v4 #5

merged 1 commit into from
Sep 15, 2023

Conversation

ayushmanchhabra
Copy link
Contributor

@ayushmanchhabra ayushmanchhabra commented Aug 22, 2023

Came across this warning while installing the module:

WARN  Issues with peer dependencies found
.
└─┬ @nightwatch/react 3.1.0
  └── ✕ unmet peer @vitejs/plugin-react@^3.0.1: found 4.0.3

This PR updates @vitejs/plugin-react peerDep to v4. I looked at the release notes for Vite and Vite React plugin but didn't see any breaking changes. Let me know if this breaks anything, I'd be happy to fix.

@ayushmanchhabra ayushmanchhabra marked this pull request as ready for review August 22, 2023 18:42
@beatfactor beatfactor merged commit 41d0d1b into nightwatchjs:main Sep 15, 2023
3 checks passed
@ayushmanchhabra ayushmanchhabra deleted the build/vite-react branch September 15, 2023 22:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants