FIx before hook giving TS error with NightwatchBrowser. (#4004)

nightwatchjs · Jan 25, 2024 · ba2ad45 · ba2ad45
1 parent 1798bba
commit ba2ad45
Show file tree

Hide file tree

Showing 2 changed files with 10 additions and 4 deletions.
diff --git a/types/index.d.ts b/types/index.d.ts
@@ -567,6 +567,9 @@ export interface NightwatchAPI
 // tslint:disable-next-line:no-empty-interface
 export interface NightwatchCustomPageObjects { }
 
+/**
+ * @deprecated Use `NightwatchAPI` instead.
+ */
 export interface NightwatchBrowser
   extends NightwatchAPI,
   NightwatchComponentTestingCommands,
@@ -636,7 +639,7 @@ export interface NightwatchTestFunctions {
 }
 
 export type NightwatchTestHook = (
-  browser: NightwatchAPI,
+  browser: NightwatchBrowser,
   done: (err?: unknown) => void
 ) => void;
 

diff --git a/types/tests/index.test-d.ts b/types/tests/index.test-d.ts
@@ -6,6 +6,7 @@ import {
   NightwatchAPI,
   NightwatchAssertion,
   NightwatchAssertionsResult,
+  NightwatchBrowser,
   NightwatchClient,
   NightwatchClientObject,
   NightwatchEnsureResult,
@@ -283,10 +284,14 @@ describe('duckduckgo example', function () {
 // .tests/native/wikipedia.ts
 //
 const wikipediaAppTest: NightwatchTests = {
-  before: (client: NightwatchAPI) => {
+  before: (client: NightwatchBrowser) => {
     client.click(by.xpath('//XCUIElementTypeButton[@name="Skip"]'));
   },
 
+  after: (client: NightwatchAPI) => {
+    client.end();
+  },
+
   'Search for BrowserStack': async (client: NightwatchAPI) => {
     client
       .useXpath()
@@ -347,8 +352,6 @@ const wikipediaAppTest: NightwatchTests = {
       })
       .useCss()
       .assert.textEquals('.pcs-edit-section-title', 'BrowserStack'); // command run in webview context
-
-    client.end();
   },
 };