Merge pull request #1885 from noelyoo/safe-buffer

refactoring of new Buffer usage, which is deprecated and unsafe
nightwatchjs · Sep 21, 2018 · f626363 · f626363
2 parents eeb0a4f + d27d3c0
commit f626363
Show file tree

Hide file tree

Showing 2 changed files with 2 additions and 2 deletions.
diff --git a/lib/http/auth.js b/lib/http/auth.js
@@ -17,7 +17,7 @@ class Auth {
   }
 
   static toBase64(str) {
-    return new Buffer(str).toString('base64');
+    return Buffer.from(str).toString('base64');
   }
 }
 

diff --git a/test/src/index/testRequest.js b/test/src/index/testRequest.js
@@ -105,7 +105,7 @@ describe('test HttpRequest', function() {
     }).send();
 
     try {
-      var authHeader = new Buffer('test:test-key').toString('base64');
+      var authHeader = Buffer.from('test:test-key').toString('base64');
       assert.equal(request.httpRequest.getHeader('Authorization'), 'Basic ' + authHeader);
     } catch (err) {
       done(err);