Bug: empty strings inside shared pageobject elements cause runtime error

[GrayedFox]

The error:

// error when running tests
     Error: No selector property for element "image" Instead found properties: selector,parent,name
       at Array.forEach (native)
       at Array.forEach (native)
       at Array.forEach (native)

This error happens no matter what test is run if, inside a PageObject, I do the following:

//home pageObject
const sharedElements = {
  image: '',
  header: 'h3',
  body: 'p'
}

module.exports = {
  url() { return this.api.globals.root },
  sections: {
    main: {
      selector: '.welcome-text',
      elements: {
        title: '.welcome-text__title',
        subtitle: '.welcome-text__subtitle',
        description: '.welcome-text__description'
      }
    },
    partners: {
      commands: [sharedCommands],
      selector: '.frequent-flyer-program-partnership',
      elements: {
        milesAndMore: '.frequent-flyer-program-partnership__image:nth-of-type(1)',
        asiaMiles: '.frequent-flyer-program-partnership__image:nth-of-type(2)'
      }
    },
    benefits: {
      selector: '.benefits',
      sections: {
        waitTime: {
          commands: [sharedCommands],
          selector: '.blacklane_benefits .span3:nth-child(1)',
          elements: [sharedElements]
        },
        rates: {
          commands: [sharedCommands],
          selector: '.blacklane_benefits .span3:nth-child(2)',
          elements: [sharedElements]
        },
        drivers: {
          commands: [sharedCommands],
          selector: '.blacklane_benefits .span3:nth-child(3)',
          elements: [sharedElements]
        },
        cancellation: {
          commands: [sharedCommands],
          selector: '.blacklane_benefits .span3:nth-child(4)',
          elements: [sharedElements]
        }
      }
    }
  }
}

Putting some text inside the image value solves the problem!

[beatfactor]

Why would have an empty element id?

[GrayedFox]

No need (in my case) for an empty string - although maybe someone else would use an empty string as a placeholder.

I just wanted to point out the runtime error - since the output was confusing ("no selector property... instead found properties selector, parent, name".

I guess updating the function that checks the selector should have some safety/defensiveness against empty strings 😸

[stale]

This issue has been automatically marked as stale because it has not had any recent activity.
If possible, please retry using the latest Nightwatch version and update the issue with any relevant details. If no further activity occurs, it will be closed. Thank you for your contribution.