Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Enhancement] sendKeys should notify when you're passing in undefined #3045

Closed
MicahLC opened this issue Feb 10, 2022 · 1 comment · Fixed by #3115
Closed

[Enhancement] sendKeys should notify when you're passing in undefined #3045

MicahLC opened this issue Feb 10, 2022 · 1 comment · Fixed by #3115
Assignees

Comments

@MicahLC
Copy link
Contributor

MicahLC commented Feb 10, 2022

Is your feature request related to a problem? Please describe.

I am porting some tests to Nightwatch 2.0, and I had a test failing that was using the sendKeys API. I was passing in browser.Keys.DOWN_ARROW as part of an array of keys, when I needed to be passing in browser.Keys.ARROW_DOWN

Describe the solution you'd like

In sendKeys and other similar APIs, if the user is passing in an undefined value as part of the array arg (or on its own), the API should throw an error or somehow alert the caller that they're not passing in what they think they are.

Describe how the solution will work

Not sure on the details yet, don't have time to look at the source right now.

@harshit-bs harshit-bs self-assigned this Mar 15, 2022
@AutomatedTester
Copy link
Member

this might be better fixed in Selenium. Command is in https://github.com/SeleniumHQ/selenium/blob/trunk/javascript/node/selenium-webdriver/lib/webdriver.js#L2521-L2561

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging a pull request may close this issue.

4 participants