Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Reporter: Embrace screenshots from custom assertions #1700

Closed
wants to merge 2 commits into from
Closed

Reporter: Embrace screenshots from custom assertions #1700

wants to merge 2 commits into from

Conversation

kontrollanten
Copy link

When creating custom assertions it would be great if it would be possible to append screenshots to the report. This can eg be useful when doing visual regressions.

  • Create a new branch from master (e.g. features/my-new-feature or issue/123-my-bugfix)
  • If you're fixing a bug also create an issue if one doesn't exist yet
  • If it's a new feature explain why do you think it's necessary
  • If your change include drastic or low level changes please discuss them to make sure they will be accepted and what the impact will be
  • If your change is based on existing functionality please consider refactoring first. Pull requests that duplicate code will not make it in very quick, if at all.
  • Do not include changes that are not related to the issue at hand
  • Follow the same coding style with regards to spaces, semicolons, variable naming etc.
  • Add unit tests

@ASnow
Copy link

ASnow commented Jul 31, 2018

Please look at this

@stale
Copy link

stale bot commented Dec 13, 2018

This issue has been automatically marked as stale because it has not had any recent activity.
If possible, please retry using the latest Nightwatch version and update the issue with any relevant details. If no further activity occurs, it will be closed. Thank you for your contribution.

@stale stale bot added the stale label Dec 13, 2018
@stale stale bot closed this Dec 20, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants