Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix nightwatch -version command #3397

Merged
merged 2 commits into from Sep 23, 2022
Merged

fix nightwatch -version command #3397

merged 2 commits into from Sep 23, 2022

Conversation

swrdfish
Copy link
Member

fixes #3396

vaibhavsingh97
vaibhavsingh97 requested changes Sep 20, 2022
View reviewed changes
Copy link
Member

@vaibhavsingh97 vaibhavsingh97 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The changes look good to me, and I left comments for a few of the minor changes

lib/utils/version.js Outdated Show resolved Hide resolved
lib/utils/version.js Outdated Show resolved Hide resolved
test/src/utils/testUtils.js Outdated Show resolved Hide resolved
@beatfactor beatfactor merged commit 1fc117b into nightwatchjs:main Sep 23, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@vaibhavsingh97 vaibhavsingh97 vaibhavsingh97 approved these changes

@gravityvi gravityvi Awaiting requested review from gravityvi

@beatfactor beatfactor Awaiting requested review from beatfactor

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Nightwatch showing version as undefined in latest release
3 participants
@swrdfish @vaibhavsingh97 @beatfactor