Fix #3484 Added elementId only param in moveTo command #3517
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
gravityvi
requested changes
Dec 14, 2022
harshit-bs
force-pushed
the
issue/moveTo-3484
branch
from
0763b60
to
e9a8895
Compare
|
Whether moveTo can support pageObject variables？ @gravityvi |
gravityvi
approved these changes
Feb 9, 2023
harshit-bs
requested review from
beatfactor and
swrdfish
and removed request for
a team
AutomatedTester
requested changes
Mar 14, 2023
swrdfish
approved these changes
Mar 16, 2023
… the section element to be gone
…g done() (nightwatchjs#3490) * set tree to started immediately * if queue is not empty, wait for initial traversal to begin * remove unnecessary changes * add tests * fix tests
* Fix analytics issue
Based on this https://www.selenium.dev/blog/2021/a-tour-of-4-authentication/ This feature is currently implemented on top of Selenium 4’s CDP(Chrome DevTools Protocol) support, and so only works on those browser that support that protocol. That means it won't work in Safari. And it's not going to solve the Safari basic auth issue in selenium. See https://www.browserstack.com/docs/automate/selenium/basic-http-authentication
Co-authored-by: Prudhvi <prudhvi@browserstack.com>
* Bump Selenium Version to 4.8.0 * Removed NodeJS 12.x support
We have been adding new features to nightwatch so we need to update our keyword selection
beatfactor
pushed a commit
that referenced
this pull request
Mar 23, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issues
Changes
nullandxoffsetandyoffsetwill be 0 when nothing passed in paramselementIdargument passed thenxoffsetandyoffsetwill be 0