Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Test fix: waitForElementNotPresent #3599

Merged
merged 5 commits into from May 9, 2023
Merged

Test fix: waitForElementNotPresent #3599

merged 5 commits into from May 9, 2023

Conversation

harshit-bs
Copy link
Member

@harshit-bs harshit-bs commented Feb 6, 2023 •
edited by gravityvi

Changes :

  • Fixed a test of waitForElementNotPresent
  • Removed the done() callback to end the test after an assertion. Because if the assertion fails, done() will never be called.

Impact

@harshit-bs harshit-bs changed the title Test fix: Test fix Feb 6, 2023
@harshit-bs harshit-bs changed the title Test fix Test fix: waitForElementNotPresent Feb 6, 2023
@swrdfish
Copy link
Member

swrdfish commented Mar 7, 2023

@harshit-bs the failing windows test needs a look. Maybe increase the timeout a bit more and check?

@AutomatedTester AutomatedTester merged commit c6f5f3b into nightwatchjs:main May 9, 2023
7 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@beatfactor beatfactor beatfactor left review comments

@garg3133 garg3133 garg3133 left review comments

@swrdfish swrdfish swrdfish approved these changes

@gravityvi gravityvi gravityvi approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
6 participants
@harshit-bs @swrdfish @beatfactor @gravityvi @garg3133 @AutomatedTester