Types migration #3714
Merged
Types migration #3714
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
garg3133
reviewed
May 8, 2023
There was a problem hiding this comment.
A lot of commits from DefinitelyTyped repo are not included in this PR (commits from Feb 21 and newer are missing). Is there any way we can include those without much manual work?
Apart from that, a few things missing:
- Include
"types"infilesconfig ofpackage.json. - Set
typesconfig ofpackage.jsonto"./lib/index.d.ts": https://www.typescriptlang.org/docs/handbook/declaration-files/publishing.html#including-declarations-in-your-npm-package
garg3133
reviewed
May 8, 2023
Co-authored-by: Priyansh Garg <39924567+garg3133@users.noreply.github.com>
Co-authored-by: Priyansh Garg <39924567+garg3133@users.noreply.github.com>
vaibhavsingh97
force-pushed
the
feature/types
branch
from
f04af12
to
c4bb821
Compare
| NightwatchComponentTestingCommands, | ||
| NightwatchCustomCommands { } | ||
|
|
||
| export interface NightwatchComponentTestingCommands { |
There was a problem hiding this comment.
After discussing with @beatfactor and @swrdfish we need to see what happens if this goes in and there is a clash? Does simply override or does it error? Can we see download numbers of the version that has been released and maybe remove it there and handle fall out?
@garg3133 and @vaibhavsingh97 can you look into this for me?
There was a problem hiding this comment.
No problem at all! Plugins can override the types, so we can easily deprecate it.
* Add missing types in chrome-options. * Add example for custom-assertions. * Replace NightwatchBrowser with NightwatchAPI in globals. * Fix screenshot type. * Add section in expect types. * Add type for app global and isAppiumClient. * Partial merge of final DT PR. * Add cookie and executeScript types. * Add sessions and navigation types. * Add types for window and frame commands. * Add types for webdriver elements api. * Fix indentation in chrome-options
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PRs moves the DT types into the project and adds additional types for the new
element()apis in v3. Also adds separate type declarations for custom assertion, custom commands, and updates page object types.TODO: