New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Remove dependency on driver binaries, fallback to selenium-manager #3717
Remove dependency on driver binaries, fallback to selenium-manager #3717
Conversation
how does the selenium-manager work? |
If no binary is provided, it goes ahead and downloads the required driver binaries based on the browser installed on the system. If something is specified then that is going to be used. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Should we remove downloadMessages
method as well?
lib/transport/selenium-webdriver/service-builders/base-service.js
Outdated
Show resolved
Hide resolved
lib/transport/selenium-webdriver/service-builders/base-service.js
Outdated
Show resolved
Hide resolved
… instead" This reverts commit 3a1e924.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good. Should we update nightwatch init package and remove the process of downloading browser drivers after that this would really useful.
@gravityvi we should, Traking here: nightwatchjs/create-nightwatch#87 |
No description provided.