Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add types checking workflows #3743

Merged
merged 5 commits into from
May 22, 2023

Conversation

garg3133
Copy link
Member

@garg3133 garg3133 commented May 22, 2023

Add workflows to check if type changes are made in the PR.

We need to use workflow in this way because pull_request event does not have write access on its own, so we save the result as an artifact and use the result in a separate workflow run which does have write access on the repo.

Please read: https://securitylab.github.com/research/github-actions-preventing-pwn-requests/

garg3133#4 shows that this PR works across forks as well.

@AutomatedTester AutomatedTester merged commit ac1a1ff into nightwatchjs:main May 22, 2023
16 checks passed
@garg3133 garg3133 deleted the types-workflow branch May 23, 2023 04:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants