Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix elements and commands property issue with POM. #3788

Merged
merged 2 commits into from
Jul 17, 2023
Merged

Fix elements and commands property issue with POM. #3788

merged 2 commits into from
Jul 17, 2023

Conversation

garg3133
Copy link
Member

Fixes: #3783, #3784

@garg3133 garg3133 linked an issue Jun 29, 2023 that may be closed by this pull request
TypeScript page object commands property only accepts arrays in 3.0.1 #3784
Closed
@garg3133
Copy link
Member Author

Tests are remaining to be added here.

@AutomatedTester AutomatedTester merged commit de35330 into nightwatchjs:main Jul 17, 2023
17 checks passed
@garg3133 garg3133 deleted the fix-page-objects-types branch July 17, 2023 12:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@swrdfish swrdfish swrdfish approved these changes

@vaibhavsingh97 vaibhavsingh97 vaibhavsingh97 approved these changes

@AutomatedTester AutomatedTester Awaiting requested review from AutomatedTester

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
4 participants
@garg3133 @swrdfish @vaibhavsingh97 @AutomatedTester